[Github-comments] [geany/geany] Proxy Plugins Filename Pattern Matching (#1236)
Matthew Brush
notifications at xxxxx
Mon Oct 24 19:27:06 UTC 2016
> It was suggested by you or maybe b4n
Ah right, I made [a PR for it](https://github.com/kugel-/geany/pull/3), but you closed without merging my commits.
Still I don't really see what it buys you, the example proxy change would then look like this instead of above:
```c
...
const gchar *patterns[4] = { NULL };
if (geany_api_version() >= 230)
{
patterns[0] = "*.so";
patterns[1] = "*.dll";
patterns[2] = "*.plugin";
}
else
{
patterns[0] = "so";
patterns[1] = "dll";
patterns[2] = "plugin";
}
geany_plugin_register_proxy(plugin, patterns);
...
```
Not really an improvement over just using `GEANY_API_VERSION` with the preprocessor, unless I misunderstand?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1236#issuecomment-255840244
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20161024/8f425cee/attachment.html>
More information about the Github-comments
mailing list