<blockquote>
<p>It was suggested by you or maybe b4n</p>
</blockquote>

<p>Ah right, I made <a href="https://github.com/kugel-/geany/pull/3">a PR for it</a>, but you closed without merging my commits.</p>

<p>Still I don't really see what it buys you, the example proxy change would then look like this instead of above:</p>

<div class="highlight highlight-source-c"><pre>...
  <span class="pl-k">const</span> gchar *patterns[<span class="pl-c1">4</span>] = { <span class="pl-c1">NULL</span> };
  <span class="pl-k">if</span> (geany_api_version() >= <span class="pl-c1">230</span>)
  {
    patterns[<span class="pl-c1">0</span>] = <span class="pl-s"><span class="pl-pds">"</span>*.so<span class="pl-pds">"</span></span>;
    patterns[<span class="pl-c1">1</span>] = <span class="pl-s"><span class="pl-pds">"</span>*.dll<span class="pl-pds">"</span></span>;
    patterns[<span class="pl-c1">2</span>] = <span class="pl-s"><span class="pl-pds">"</span>*.plugin<span class="pl-pds">"</span></span>;
  }
  <span class="pl-k">else</span>
  {
    patterns[<span class="pl-c1">0</span>] = <span class="pl-s"><span class="pl-pds">"</span>so<span class="pl-pds">"</span></span>;
    patterns[<span class="pl-c1">1</span>] = <span class="pl-s"><span class="pl-pds">"</span>dll<span class="pl-pds">"</span></span>;
    patterns[<span class="pl-c1">2</span>] = <span class="pl-s"><span class="pl-pds">"</span>plugin<span class="pl-pds">"</span></span>;
  }
  <span class="pl-en">geany_plugin_register_proxy</span>(plugin, patterns);
...</pre></div>

<p>Not really an improvement over just using <code>GEANY_API_VERSION</code> with the preprocessor, unless I misunderstand?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1236#issuecomment-255840244">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ-kaEQZ7L20TUxdr1KYj6vy9-4doks5q3QaKgaJpZM4J_6i1">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ5duLIrlEEVFotWyszHAyKAd2aRgks5q3QaKgaJpZM4J_6i1.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1236#issuecomment-255840244"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@codebrainz in #1236: \u003e It was suggested by you or maybe b4n\r\n\r\nAh right, I made [a PR for it](https://github.com/kugel-/geany/pull/3), but you closed without merging my commits.\r\n\r\nStill I don't really see what it buys you, the example proxy change would then look like this instead of above:\r\n\r\n```c\r\n...\r\n  const gchar *patterns[4] = { NULL };\r\n  if (geany_api_version() \u003e= 230)\r\n  {\r\n    patterns[0] = \"*.so\";\r\n    patterns[1] = \"*.dll\";\r\n    patterns[2] = \"*.plugin\";\r\n  }\r\n  else\r\n  {\r\n    patterns[0] = \"so\";\r\n    patterns[1] = \"dll\";\r\n    patterns[2] = \"plugin\";\r\n  }\r\n  geany_plugin_register_proxy(plugin, patterns);\r\n...\r\n```\r\n\r\nNot really an improvement over just using `GEANY_API_VERSION` with the preprocessor, unless I misunderstand?"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1236#issuecomment-255840244"}}}</script>