Am 24.10.2016 um 21:27 schrieb Matthew Brush:<br>
>     It was suggested by you or maybe b4n<br>
><br>
> Ah right, I made a PR for it <https://github.com/kugel-/geany/pull/3>,<br>
> but you closed without merging my commits.<br>
<br>
<br>
You suggested to not merge it until an actual use case arises.<br>
<br>
<br>
><br>
> Still I don't really see what it buys you, the example proxy change<br>
> would then look like this instead of above:<br>
><br>
> ...<br>
>   const gchar *patterns[4] = { NULL };<br>
>   if (geany_api_version() >= 230)<br>
>   {<br>
>     patterns[0] = "*.so";<br>
>     patterns[1] = "*.dll";<br>
>     patterns[2] = "*.plugin";<br>
>   }<br>
>   else<br>
>   {<br>
>     patterns[0] = "so";<br>
>     patterns[1] = "dll";<br>
>     patterns[2] = "plugin";<br>
>   }<br>
>   geany_plugin_register_proxy(plugin, patterns);<br>
> ...<br>
><br>
> Not really an improvement over just using |GEANY_API_VERSION| with the<br>
> preprocessor, unless I misunderstand?<br>
><br>
<br>
<br>
The improvement is you can upgrade Geany without recompiling Peasy. But <br>
if yea, if the ABI version is changed it needs to be recompiled anyway.<br>
<br>
I simply would like to avoid having to recompile Peasy between 1.28 and <br>
1.29, but don't mind if it's too much work.<br>
<br>
Best regards<br>
<br>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1236#issuecomment-256136273">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ32t0f7Imj0Dm-8nS68kKzR4buJQks5q3k6ngaJpZM4J_6i1">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJzOomKO6xPbtGUe1pgq3LHOoMs7Yks5q3k6ngaJpZM4J_6i1.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1236#issuecomment-256136273"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@kugel- in #1236: Am 24.10.2016 um 21:27 schrieb Matthew Brush:\n\u003e     It was suggested by you or maybe b4n\n\u003e\n\u003e Ah right, I made a PR for it \u003chttps://github.com/kugel-/geany/pull/3\u003e,\n\u003e but you closed without merging my commits.\n\n\nYou suggested to not merge it until an actual use case arises.\n\n\n\u003e\n\u003e Still I don't really see what it buys you, the example proxy change\n\u003e would then look like this instead of above:\n\u003e\n\u003e ...\n\u003e   const gchar *patterns[4] = { NULL };\n\u003e   if (geany_api_version() \u003e= 230)\n\u003e   {\n\u003e     patterns[0] = \"*.so\";\n\u003e     patterns[1] = \"*.dll\";\n\u003e     patterns[2] = \"*.plugin\";\n\u003e   }\n\u003e   else\n\u003e   {\n\u003e     patterns[0] = \"so\";\n\u003e     patterns[1] = \"dll\";\n\u003e     patterns[2] = \"plugin\";\n\u003e   }\n\u003e   geany_plugin_register_proxy(plugin, patterns);\n\u003e ...\n\u003e\n\u003e Not really an improvement over just using |GEANY_API_VERSION| with the\n\u003e preprocessor, unless I misunderstand?\n\u003e\n\n\nThe improvement is you can upgrade Geany without recompiling Peasy. But \nif yea, if the ABI version is changed it needs to be recompiled anyway.\n\nI simply would like to avoid having to recompile Peasy between 1.28 and \n1.29, but don't mind if it's too much work.\n\nBest regards\n\n"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1236#issuecomment-256136273"}}}</script>