[Github-comments] [geany/geany] Start porting to GSettings (#1257)

[Matthew Brush]

codebrainz commented on this pull request.



> @@ -41,6 +41,14 @@ static void on_sidebar_pos_left_changed(GSettings *settings, gchar *key, gpointe
 }
 
 
+static void on_editor_font_changed(GSettings *settings, gchar *key, gpointer user_data)
+{

Here is the difference:

```diff
diff --git a/src/settings.c b/src/settings.c
index 96e0573..d620595 100644
--- a/src/settings.c
+++ b/src/settings.c
@@ -38,25 +38,24 @@
 GSettings *geany_settings = NULL;
 
 
-static void on_sidebar_pos_left_changed(GSettings *settings, gchar *key, gpointer user_data)
+static void on_setting_changed(GSettings *settings, gchar *key, gpointer user_data)
 {
-	sidebar_set_position_left(g_settings_get_boolean(settings, key));
-}
-
-
-static void on_editor_font_changed(GSettings *settings, gchar *key, gpointer user_data)
-{
-	g_free(interface_prefs.editor_font);
-	interface_prefs.editor_font = g_settings_get_string(settings, key);
-	ui_set_editor_font(interface_prefs.editor_font);
-}
-
-
-static void on_symbols_font_changed(GSettings *settings, gchar *key, gpointer user_data)
-{
-	g_free(interface_prefs.tagbar_font);
-	interface_prefs.tagbar_font = g_settings_get_string(settings, key);
-	ui_set_symbols_font(interface_prefs.tagbar_font);
+	if (g_strcmp0(key, "sidebar-pos-left") == 0)
+	{
+		sidebar_set_position_left(g_settings_get_boolean(settings, key));
+	}
+	else if (g_strcmp0(key, "editor-font") == 0)
+	{
+		g_free(interface_prefs.editor_font);
+		interface_prefs.editor_font = g_settings_get_string(settings, key);
+		ui_set_editor_font(interface_prefs.editor_font);
+	}
+	else if (g_strcmp0(key, "symbols-font") == 0)
+	{
+		g_free(interface_prefs.tagbar_font);
+		interface_prefs.tagbar_font = g_settings_get_string(settings, key);
+		ui_set_symbols_font(interface_prefs.tagbar_font);
+	}
 }
 
 
@@ -75,9 +74,9 @@ static void settings_bind_main(GSettings *settings)
 	interface_prefs.editor_font = g_settings_get_string(geany_settings, "editor-font");
 	interface_prefs.tagbar_font = g_settings_get_string(geany_settings, "symbols-font");
 
-	g_signal_connect(settings, "changed::sidebar-pos-left", G_CALLBACK(on_sidebar_pos_left_changed), NULL);
-	g_signal_connect(settings, "changed::editor-font", G_CALLBACK(on_editor_font_changed), NULL);
-	g_signal_connect(settings, "changed::symbols-font", G_CALLBACK(on_symbols_font_changed), NULL);
+	g_signal_connect(settings, "changed::sidebar-pos-left", G_CALLBACK(on_setting_changed), NULL);
+	g_signal_connect(settings, "changed::editor-font", G_CALLBACK(on_setting_changed), NULL);
+	g_signal_connect(settings, "changed::symbols-font", G_CALLBACK(on_setting_changed), NULL);
 }
 
 
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1257
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20161007/1fd02c1c/attachment.html>