[Github-comments] [geany/geany] Start porting to GSettings (#1257)

[elextr]

elextr commented on this pull request.



> @@ -41,6 +41,14 @@ static void on_sidebar_pos_left_changed(GSettings *settings, gchar *key, gpointe
 }
 
 
+static void on_editor_font_changed(GSettings *settings, gchar *key, gpointer user_data)
+{

The `editor_font` and `symbols_font` do the same thing, so they could be handled the way I proposed above and use the same callback.  There can be different callbacks, its not a choice between one callback and one per setting.

And if you are going to select stuff, at least make it a switch on an enum, not a series of strcmps :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1257
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20161007/c5388a72/attachment.html>