<p><b>@codebrainz</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1257">src/settings.c</a>:</p>
<pre style='color:#555'>> @@ -41,6 +41,14 @@ static void on_sidebar_pos_left_changed(GSettings *settings, gchar *key, gpointe
 }
 
 
+static void on_editor_font_changed(GSettings *settings, gchar *key, gpointer user_data)
+{
</pre>
<p>Here is the difference:</p>

<div class="highlight highlight-source-diff"><pre><span class="pl-c1">diff --git a/src/settings.c b/src/settings.c</span>
index 96e0573..d620595 100644
<span class="pl-md">--- a/src/settings.c</span>
<span class="pl-mi1">+++ b/src/settings.c</span>
<span class="pl-mdr">@@ -38,25 +38,24 @@</span>
 GSettings *geany_settings = NULL;


<span class="pl-md">-static void on_sidebar_pos_left_changed(GSettings *settings, gchar *key, gpointer user_data)</span>
<span class="pl-mi1">+static void on_setting_changed(GSettings *settings, gchar *key, gpointer user_data)</span>
 {
<span class="pl-md">-   sidebar_set_position_left(g_settings_get_boolean(settings, key));</span>
<span class="pl-md">-}</span>
<span class="pl-md">-</span>
<span class="pl-md">-</span>
<span class="pl-md">-static void on_editor_font_changed(GSettings *settings, gchar *key, gpointer user_data)</span>
<span class="pl-md">-{</span>
<span class="pl-md">-   g_free(interface_prefs.editor_font);</span>
<span class="pl-md">-   interface_prefs.editor_font = g_settings_get_string(settings, key);</span>
<span class="pl-md">-   ui_set_editor_font(interface_prefs.editor_font);</span>
<span class="pl-md">-}</span>
<span class="pl-md">-</span>
<span class="pl-md">-</span>
<span class="pl-md">-static void on_symbols_font_changed(GSettings *settings, gchar *key, gpointer user_data)</span>
<span class="pl-md">-{</span>
<span class="pl-md">-   g_free(interface_prefs.tagbar_font);</span>
<span class="pl-md">-   interface_prefs.tagbar_font = g_settings_get_string(settings, key);</span>
<span class="pl-md">-   ui_set_symbols_font(interface_prefs.tagbar_font);</span>
<span class="pl-mi1">+   if (g_strcmp0(key, "sidebar-pos-left") == 0)</span>
<span class="pl-mi1">+   {</span>
<span class="pl-mi1">+       sidebar_set_position_left(g_settings_get_boolean(settings, key));</span>
<span class="pl-mi1">+   }</span>
<span class="pl-mi1">+   else if (g_strcmp0(key, "editor-font") == 0)</span>
<span class="pl-mi1">+   {</span>
<span class="pl-mi1">+       g_free(interface_prefs.editor_font);</span>
<span class="pl-mi1">+       interface_prefs.editor_font = g_settings_get_string(settings, key);</span>
<span class="pl-mi1">+       ui_set_editor_font(interface_prefs.editor_font);</span>
<span class="pl-mi1">+   }</span>
<span class="pl-mi1">+   else if (g_strcmp0(key, "symbols-font") == 0)</span>
<span class="pl-mi1">+   {</span>
<span class="pl-mi1">+       g_free(interface_prefs.tagbar_font);</span>
<span class="pl-mi1">+       interface_prefs.tagbar_font = g_settings_get_string(settings, key);</span>
<span class="pl-mi1">+       ui_set_symbols_font(interface_prefs.tagbar_font);</span>
<span class="pl-mi1">+   }</span>
 }


<span class="pl-mdr">@@ -75,9 +74,9 @@</span> static void settings_bind_main(GSettings *settings)
    interface_prefs.editor_font = g_settings_get_string(geany_settings, "editor-font");
    interface_prefs.tagbar_font = g_settings_get_string(geany_settings, "symbols-font");

<span class="pl-md">-   g_signal_connect(settings, "changed::sidebar-pos-left", G_CALLBACK(on_sidebar_pos_left_changed), NULL);</span>
<span class="pl-md">-   g_signal_connect(settings, "changed::editor-font", G_CALLBACK(on_editor_font_changed), NULL);</span>
<span class="pl-md">-   g_signal_connect(settings, "changed::symbols-font", G_CALLBACK(on_symbols_font_changed), NULL);</span>
<span class="pl-mi1">+   g_signal_connect(settings, "changed::sidebar-pos-left", G_CALLBACK(on_setting_changed), NULL);</span>
<span class="pl-mi1">+   g_signal_connect(settings, "changed::editor-font", G_CALLBACK(on_setting_changed), NULL);</span>
<span class="pl-mi1">+   g_signal_connect(settings, "changed::symbols-font", G_CALLBACK(on_setting_changed), NULL);</span>
 }

</pre></div>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1257">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ6Jf2fOWKKVGx8AC8p73AgSucVxaks5qxvrxgaJpZM4KPeqz">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJzB9ALPHLMqGy2oACyMBoGED2hncks5qxvrxgaJpZM4KPeqz.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1257"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@codebrainz commented on #1257"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1257"}}}</script>