[Github-comments] [geany] If more tags are found during tag definition/declaration goto, let user select which one to use (#406)

[Colomban Wendling]

> +static gint compare_tags(gconstpointer ptr1, gconstpointer ptr2)
> +{
> +	gint res;
> +	TMTag *t1 = *((TMTag **) ptr1);
> +	TMTag *t2 = *((TMTag **) ptr2);
> +
> +	res = g_strcmp0(t1->file->short_name, t2->file->short_name);
> +	if (res != 0)
> +		return res;
> +	return t1->line - t2->line;
> +}
> +
> +
> +static TMTag *find_best_goto_tag(GPtrArray *tags)
> +{
> +	GeanyDocument *doc = document_get_current();

I'd rather pass this as an argument, lowering the environmental factor of this function

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/406/files#r52834333
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160213/4d667071/attachment.html>