[Github-comments] [geany] If more tags are found during tag definition/declaration goto, let user select which one to use (#406)

[Colomban Wendling]

> +	{
> +		GPtrArray *tags;
> +		TMTag *tag, *best_tag;
> +
> +		g_ptr_array_sort(workspace_tags, compare_tags);
> +		best_tag = find_best_goto_tag(workspace_tags);
> +
> +		tags = g_ptr_array_new();
> +		if (best_tag)
> +			g_ptr_array_add(tags, best_tag);
> +		foreach_ptr_array(tag, i, workspace_tags)
> +		{
> +			if (tag != best_tag)
> +				g_ptr_array_add(tags, tag);
> +		}
> +		show_goto_popup(tags, best_tag != 0);

`0` is not a pointer, should rather be `NULL`

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/406/files#r52834293
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160213/1484626c/attachment.html>