[Github-comments] [geany] If more tags are found during tag definition/declaration goto, let user select which one to use (#406)

[Colomban Wendling]

> +				TAG_COLUMN, tmtag, -1);
> +
> +		g_free(text);
> +		g_free(fname);
> +		first = FALSE;
> +	}
> +
> +	path = gtk_tree_path_new_first();
> +	gtk_tree_view_set_cursor (GTK_TREE_VIEW(tag_goto_tree_view), path, NULL, FALSE);
> +	gtk_tree_path_free(path);
> +
> +	gtk_window_present(GTK_WINDOW(tag_goto_popup));
> +}
> +
> +
> +static gint compare_tags(gconstpointer ptr1, gconstpointer ptr2)

not directly clear how it sorts the tags, so maybe either rename the function to be explicit, or at least add a small comment so one doesn't have to read the body just to get "ah, k, just sorts by basename, then line" :)

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/406/files#r52834340
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160213/affed7d6/attachment.html>