[Github-comments] [geany] Fix for "Open in New Window". (#637)

[elextr]

Basic logic looks fine, and I personally like the table driven approach, but as I have said on other versions of this change, I don't agree with forcing the same config so I won't be testing or committing it.

Disagree with @codebrainz on the need to split a PR of this size now its not made in steps.  That is just a relative judgement thing, but agree with him that in general it can be useful if things are done stepwise in *complete, compilable, bisectable* commits.

Agree with @codebrainz that this PR makes some improvements for most users, so it could be used until some magic wand makes the right solution possible.

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/637#issuecomment-137297627
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20150902/2fd6afce/attachment.html>