[Github-comments] [geany] Fix for "Open in New Window". (#637)

Matthew Brush notifications at xxxxx
Thu Sep 3 02:08:34 UTC 2015


> Basic logic looks fine, and I personally like the table driven approach [...]

To be clear, I didn't mean to imply it was a bad approach or anything, just that it's relatively complex and having it combined in with the other changes makes it more difficult to review, fully understand (especially in the future), or event to back-out specific parts if bugs are found, etc.

> Disagree with @codebrainz on the need to split a PR of this size now its not made in steps [...]

Depends if the intermediate commits exist and were just squashed together or not. If they exist, it's trivial unsplit, otherwise it might arguably be too much hassle.

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/637#issuecomment-137301459
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20150902/15ab0bc6/attachment.html>


More information about the Github-comments mailing list