[Github-comments] [geany-plugins] Automake (#277)

[Thomas Martitz]

>* full conversion (don't leave a third-or-so of the plugins recursive)

...

>
>However, while I do like the technical advantage of the result (faster,
>parallelized builds from the bottom-up, less Make overhead, etc…), I
>don't really like the changes this PR makes.  It adds duplication on
>stuff that was nicely generic (i.e. `plugindoc` stuff) and has some
>subtle gotchas in the recursive vs. non-recursive versions
>(`SHORTNAME`, conditionals, custom targets, etc.).
>So in the end, I'm really not sure I like the changes, as I find the
>benefits not enough for the (current) added complexity.


So this is why I haven't converted all plugins yet.  Merging is far from guaranteed. So I would like to get a decision based the current conversion with all other remarks fixed.


---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/277#issuecomment-160717018
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20151130/7fa70d3b/attachment.html>