[Github-comments] [geany-plugins] Automake (#277)

Colomban Wendling notifications at xxxxx
Mon Nov 30 16:38:17 UTC 2015


> -	ao_wrapwords.h \
> -	ao_copyfilepath.h \
> -	addons.c \
> -	ao_blanklines.c \
> -	ao_doclist.c \
> -	ao_openuri.c \
> -	ao_systray.c \
> -	ao_bookmarklist.c \
> -	ao_markword.c \
> -	ao_tasks.c \
> -	ao_xmltagging.c \
> -	ao_wrapwords.c \
> -	ao_copyfilepath.c
> -
> -addons_la_LIBADD = $(COMMONLIBS)
> -
>  include $(top_srcdir)/build/cppcheck.mk

No, I mean that `make check` (from the top-level) should have the same behavior as running `make check` from each sub-directory.  As *build/cppcheck.mk* adds rules to be executed upon `make check`, and that this is only included in the recursive Makefile, these checks will only be run when running `make check` from the sub-directories and never from the top-level.

Before these changes, `make check` was recursive (like most common targets, like *all*), and so running it from the top-level ran checks in the whole tree.  Now, `cppcheck` checks are missing from all plugins you converted to non-recursiveness when invoked non-recursively.

You can probably understand quite easily by giving a look at *build/cppcheck.mk*, knowing that `check-local` is a dependency of the `check` target.

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/277/files#r46167175
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20151130/30cae76f/attachment.html>


More information about the Github-comments mailing list