[Github-comments] [geany-plugins] Automake (#277)

Colomban Wendling notifications at xxxxx
Mon Nov 30 15:34:00 UTC 2015


At the very least this has to be fixed/corrected:

* leftovers
* fix *cppcheck* support
* full conversion (don't leave a third-or-so of the plugins recursive) (I know this is known, just want to point out to @frlan)
* documentation update (*HACKING*)

However, while I do like the technical advantage of the result (faster, parallelized builds from the bottom-up, less Make overhead, etc…), I don't really like the changes this PR makes.  It adds duplication on stuff that was nicely generic (i.e. `plugindoc` stuff) and has some subtle gotchas in the recursive vs. non-recursive versions (`SHORTNAME`, conditionals, custom targets, etc.).
So in the end, I'm really not sure I like the changes, as I find the benefits not enough for the (current) added complexity.

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/277#issuecomment-160662572
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20151130/404ebb62/attachment.html>


More information about the Github-comments mailing list