[Geany-Devel] Smalltalk support in Geany
lists.ban at xxxxx
Thu Nov 14 12:17:25 UTC 2019
Le 13/11/2019 à 22:24, Lex Trotman a écrit :
> Geany is a volunteer project, nothing will happen unless "somebody"
> submits a pull request. Not saying it will be accepted, but if nobody
> has done it to date it likely means nobody uses smalltalk and it isn't
> going to happen otherwise.
I myself think a patch is fine, and this one looks quite good at first
glance (assuming the lexer is Scintilla's upstream one).
All I can notice is that:
* the scintilla/scintilla_changes.patch patch needs updating
* there seem to be an indentation issue in src/filetypes.c
* maybe comment_single shouldn't be set to an empty value
I didn't test, but apart from that it looks good (not tested yet).
More information about the Devel