[Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins
magnetudinbuda at xxxxx
Thu May 28 22:10:06 UTC 2015
I had a look at
This plugin does something similar to GeanyHighlightSelectedWord.
The quick-search.c calls Geany's search_find_text several times in one
processing, and each time a regex would be recompiled in search_find_text.
This is, I guess, a small cost when the regex is just a string.
GeanyHighlightSelectedWord implements search using KMP.
Designs differ, but functionality is alike. I would keep both this plugins,
and not try to merge them.
Have a great day,
Marius Ioan Buzea
On Thu, 5/28/15, Colomban Wendling <lists.ban at herbesfolles.org> wrote:
Subject: Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins
To: "marius buzea" <magnetudinbuda at yahoo.com>, "Geany development list" <devel at lists.geany.org>
Date: Thursday, May 28, 2015, 12:21 AM
Le 27/05/2015 14:25, marius buzea a écrit :
> I would like to add
GeanyHighlightSelectedWords, to Geany Plugins.
> Would it be okay that I do a git
pull-request for doing this? […]
Sure. I see some other people suggested
already included plugins might
something similar, so I'll let you check whether you can
your efforts or not, but we
generally are happy including any plugin :)
(well, given it's of decent quality, but we can even
help with that if
we think something might
know there would be some things I would need to do before,
> replace the Makefile with
Makefile.am, the autotools, automake way,
> and write a README file using restructured
text content so that that
> README file
can be converted to html. Maybe there is more
> should be done.
It's pretty much it. Build
system integration, and internationalization
integration. But we can help with both, you
can read HACKING, and
is quite easy.
More information about the Devel