[Geany-devel] SM r4968 bug - and more

[Eugene Arshinov]

On Fri, 4 Jun 2010 21:58:09 +0400%
Eugene Arshinov <earshinov at gmail.com> wrote:

> On Fri, 4 Jun 2010 19:58:15 +0300%
> Dimitar Zhekov <dimitar.zhekov at gmail.com> wrote:
> 
> > On Fri, 4 Jun 2010 11:48:22 +0400
> > Eugene Arshinov <earshinov at gmail.com> wrote:
> > 
> > > On Thu, 3 Jun 2010 19:14:39 +0300%
> > > Dimitar Zhekov <dimitar.zhekov at gmail.com> wrote:
> > > 
> > > > With the sm_set_runtime_props() call in
> > > > sm_save_yourself_callback() commented out, 4968 does not kill
> > > > the session on startup.
> > > 
> > > Interesting.  It's worth debugging sm_set_runtime_props() with gdb
> > > step-by-step and see when session is killed.
> > 
> > That didn't work, the session was killed asynchronously. But while
> > trying to trace geany with nemiver, the session remained stable -
> > only geany-4968 was closed, and a new geany was started, as if the
> > SM tried to clone or restart it (hint restart now?), using the
> > program name from the legacy SM protocol.
> > 
> > Anyway, commenting out SmcSetProperties() for _both_ the restart and
> > clone commands resulted in a stable running Geany. So there's
> > probably something wrong with their prop values.
> > 
> 
> I'll look at them.
> 

I looked through the code, but did not find anything that could cause
the bug.  What happens if you leave SmcSetProperties() for restart and
clone commands uncommented, but comment out one of/both sm_cmd_props()
and sm_files_props() calls? 

> > > Well, in addition to removing the check I will have to forbid
> > > reading file list from config when an instance is started by
> > > session manager. Not too hard, though.
> > 
> > Yes, a --no-session will do. You should mark it as non-persistent
> > anyway, otherwise a geany once started with --no-session will come
> > empty (no files open) each time the session is restored.
> > 
> 
> Hm, I don't understand the last point.  Why will no-session'ed
> instances come empty if their files are passed via command-line?  My
> original thought was not using --no-session, but simply don't load
> files from config if --libsm-client-id is passed.
> 
> > > To speak truth, when I wrote this code I didn't think about
> > > several main instances.  I still does not understand why they are
> > > needed. Lex explained me why opening one project in several
> > > instances can be useful, but opening several main instances seems
> > > to be even more crazy stuff :)
> > 
> > I have two main instances running (with sm) since may-19: one on 
> > desktop 1 with BDF/FNA files, and another on desktop 2 with geany
> > source files. My file manager is set to open bdf/fna with geany
> > socket file "desktop1", and [ch] files with "desktop2".
> > 
> > But it'll be better to write a short script that runs geany with
> > socket "desktop<current>". That's how nedit worked, very convinient.
> > 
> 
> Yes, this is indeed useful.
> 

Now I always specify file names in restart command, thanks for
suggestions.  I'll commit it soon, after I'm confident enough that it
works.

> Best regards,
> Eugene.