[Geany-devel] [PATCH] Changebar port from codeblocks
techet at xxxxx
Sun Jun 13 17:44:16 UTC 2010
2010/6/13 Enrico Tröger <enrico.troeger at uvena.de>:
> On Sat, 12 Jun 2010 20:23:56 +0200, Jiří wrote:
>> 2010/6/12 Enrico Tröger <enrico.troeger at uvena.de>:
>> > On Thu, 10 Jun 2010 09:29:18 +1000, Lex wrote:
>> >> Hi Jiri,
>> >> I'd recommend that you send your patches as attachments, putting
>> >> them in the mail body can get them wrapped.
>> > +1, Nick also said this above.
>> Sorry, I can resend them again, just tell me. (I don't want to spam
>> the mailing list too much - I have already caused a nasty email storm
>> on your list).
> I know you used git send-email and so the patch got into the body. But
> I didn't understand yet why git send-email does this by default at all.
> Copying patches from the mail body is very error-prone due to various
> mail clients and how they handle and display contents. Do the git guys
> expect everyone to use mutt? :)
> Seriously, this should not sound like a rant or something, I'm
> seriously asking how such mails are meant to be handled.
As Frank said, it uses the mbox format supported by many mail clients.
There's a nice short git tutorial here:
that shows typical git workflows.
> As saying below, I personally don't want to get this feature into Geany
> before it is in mainline Scintilla, so there is probably no need to
> re-send the patch for now. But that's just me.
>> > And a bit more info would be cool, a short description and/or a
>> > screenshot. I hardly remember some new visual Scintilla features
>> > from the past which could be what the topic is about but I don't
>> > have the time to look it all up. And I don't know CodeBlocks.
>> > Thanks.
>> OK, here's a screenshot:
>> (Notice the green and yellow lines.) When you load the document, there
>> are no lines. The first time you modify a line, a yellow stripe
>> appears next to it. If you save it, it becomes green. So the
>> screenshot can be interpreted as:
>> * lines 61-64 have been modified since document loading, but these are
>> saved on the disk
>> * lines 65-69 have been modified but have not yet been saved (have
>> been modified after the last save)
>> * the remaining lines haven't been edited at all
>> I find it pretty useful for navigation in source code because you can
>> quickly visually see the places you have been working on.
> Thanks for the details.
> I remember it now, I read about it on the Scintilla mailing list I
>> It has been introduced by Neil as an experimental feature for
>> scintilla two years ago:
>> I had a discussion with Neil whether this couldn't be merged to
>> mainline scintilla, but he finds the current implementation "not good
>> Despite its (in practice not visible) limitations, I find it so much
>> useful that I decided to port it from codeblocks (which contains
>> probably the most up-to-date version). I understand that it probably
>> won't get merged to geany, but some people might find it useful too.
> I also think this could be cool. But really, I'd wish to use it from
> mainline Scintilla, so it needs to get in there before. So, maybe the
> next step should be to get in touch with Neil (again) and/or fix the
> code to be ready for the masses.
I totally agree with you. I also think that this should be merged to
the mainline scintilla first. Unfortunately I won't have free time to
spend on proper implementation (which is trickier than it may seem if
you consider it should work well with undo) in the near future (and
neither Neil has) so all I can do right now is to provide a patch when
a new scintilla is used by geany if there are some people interested
in using it (I'll do that for myself anyway).
More information about the Devel