[Geany-devel] [PATCH] Changebar port from codeblocks
frank at xxxxx
Sun Jun 13 12:04:22 UTC 2010
On Sun, 13 Jun 2010 12:48:24 +0200
Enrico Tröger <enrico.troeger at uvena.de> wrote:
> On Sat, 12 Jun 2010 20:23:56 +0200, Jiří wrote:
> > 2010/6/12 Enrico Tröger <enrico.troeger at uvena.de>:
> > > On Thu, 10 Jun 2010 09:29:18 +1000, Lex wrote:
> > >
> > >> Hi Jiri,
> > >>
> > >> I'd recommend that you send your patches as attachments, putting
> > >> them in the mail body can get them wrapped.
> > >
> > > +1, Nick also said this above.
> > >
> > Sorry, I can resend them again, just tell me. (I don't want to spam
> > the mailing list too much - I have already caused a nasty email storm
> > on your list).
> I know you used git send-email and so the patch got into the body. But
> I didn't understand yet why git send-email does this by default at all.
> Copying patches from the mail body is very error-prone due to various
> mail clients and how they handle and display contents. Do the git guys
> expect everyone to use mutt? :)
Nope, there is a corresponding command where you can put in a mbox IIRC.
> As saying below, I personally don't want to get this feature into Geany
> before it is in mainline Scintilla, so there is probably no need to
> re-send the patch for now. But that's just me.
> I also think this could be cool. But really, I'd wish to use it from
> mainline Scintilla, so it needs to get in there before. So, maybe the
> next step should be to get in touch with Neil (again) and/or fix the
> code to be ready for the masses.
I see it the same way. I rally liked what I did see on the screenshot
but don't think we should maintain another patchset inside Geany. So
I agree with Enrico suggestion on next steps.
Frank Lanitz <frank at frank.uvena.de>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 836 bytes
Desc: not available
More information about the Devel