6f5d5db and d6d4728 disabled "maintain history on reload" by default, with the intention to reenable it when we have a better method to make it discoverable for the user. This was necessary since it became enabled by default but could be surprising given Geany warned about losing data before.
This commit tries to resolve the discoverability, by providing an informational doc message that is shown once to the user, after the first reload. The doc message also gives the option to disable this feature. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/672
-- Commit Summary --
* document: show informational doc message after first reload
-- File Changes --
M src/document.c (34) M src/document.h (1) M src/documentprivate.h (1) M src/keyfile.c (2)
-- Patch Links --
https://github.com/geany/geany/pull/672.patch https://github.com/geany/geany/pull/672.diff
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672
@@ -1520,6 +1520,24 @@ void document_open_files(const GSList *filenames, gboolean readonly, GeanyFilety }
+static void on_keep_edit_history_on_reload_response(GtkWidget *bar, gint response_id, GeanyDocument *doc) +{
- if (response_id == GTK_RESPONSE_NO)
- {
file_prefs.keep_edit_history_on_reload = FALSE;document_reload_force(doc, doc->encoding);
It probably would be great if we could drop the history without actually reloading a second time (`sci_empty_undo_buffer`/`document_undo_clear`, but I'm not 100% sure why/if we don't have a unified way)
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672/files#r41074382
@@ -1545,6 +1564,21 @@ gboolean document_reload_force(GeanyDocument *doc, const gchar *forced_enc) pos = sci_get_current_position(doc->editor->sci); new_doc = document_open_file_full(doc, NULL, pos, doc->readonly, doc->file_type, forced_enc);
- if (file_prefs.keep_edit_history_on_reload && file_prefs.show_keep_edit_history_on_reload_msg)
- {
bar = document_show_message(doc, GTK_MESSAGE_INFO,on_keep_edit_history_on_reload_response,GTK_STOCK_OK, GTK_RESPONSE_ACCEPT,"Discard history", GTK_RESPONSE_NO,NULL, 0, "You can revert the buffer to the previous state ""simply by undoing unless you choose to discard the history. ""This message will not be displayed again. ""Your choice is can be changed in the various preferences.","The file has been reloaded.");
These strings need to be translatable
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672/files#r41074456
@@ -1545,6 +1564,21 @@ gboolean document_reload_force(GeanyDocument *doc, const gchar *forced_enc) pos = sci_get_current_position(doc->editor->sci); new_doc = document_open_file_full(doc, NULL, pos, doc->readonly, doc->file_type, forced_enc);
- if (file_prefs.keep_edit_history_on_reload && file_prefs.show_keep_edit_history_on_reload_msg)
- {
bar = document_show_message(doc, GTK_MESSAGE_INFO,on_keep_edit_history_on_reload_response,GTK_STOCK_OK, GTK_RESPONSE_ACCEPT,"Discard history", GTK_RESPONSE_NO,NULL, 0, "You can revert the buffer to the previous state ""simply by undoing unless you choose to discard the history. ""This message will not be displayed again. ""Your choice is can be changed in the various preferences.","The file has been reloaded.");
These messages probably need to be reviewed by @elextr
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672/files#r41074490
@@ -235,6 +235,8 @@ static void init_pref_groups(void) "use_gio_unsafe_file_saving", TRUE); stash_group_add_boolean(group, &file_prefs.keep_edit_history_on_reload, "keep_edit_history_on_reload_125", FALSE);
This needs to be renamed back to `keep_edit_history_on_reload` without the `_125` suffix to reset the default value.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672/files#r41074543
@@ -1520,6 +1520,24 @@ void document_open_files(const GSList *filenames, gboolean readonly, GeanyFilety }
+static void on_keep_edit_history_on_reload_response(GtkWidget *bar, gint response_id, GeanyDocument *doc) +{
- if (response_id == GTK_RESPONSE_NO)
- {
file_prefs.keep_edit_history_on_reload = FALSE;document_reload_force(doc, doc->encoding);
This way it's a one-liner, and the whole infomsg is a one-timer. So it's not really worth any optimization.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672/files#r41074607
I would have tried to do it differently with a checkbox to ask whether to remember the choice, but your version seems reasonable and easy to implement. I'll have to try it for real, but it looks nice.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-145170778
@@ -1545,6 +1564,21 @@ gboolean document_reload_force(GeanyDocument *doc, const gchar *forced_enc) pos = sci_get_current_position(doc->editor->sci); new_doc = document_open_file_full(doc, NULL, pos, doc->readonly, doc->file_type, forced_enc);
- if (file_prefs.keep_edit_history_on_reload && file_prefs.show_keep_edit_history_on_reload_msg)
- {
bar = document_show_message(doc, GTK_MESSAGE_INFO,on_keep_edit_history_on_reload_response,GTK_STOCK_OK, GTK_RESPONSE_ACCEPT,"Discard history", GTK_RESPONSE_NO,NULL, 0, "You can revert the buffer to the previous state ""simply by undoing unless you choose to discard the history. ""This message will not be displayed again. ""Your choice is can be changed in the various preferences.","The file has been reloaded.");
Argh yes, that was the whole point of not doing it for 1.25.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672/files#r41074748
@@ -235,6 +235,8 @@ static void init_pref_groups(void) "use_gio_unsafe_file_saving", TRUE); stash_group_add_boolean(group, &file_prefs.keep_edit_history_on_reload, "keep_edit_history_on_reload_125", FALSE);
Right, I saved that for a separate commit.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672/files#r41074931
@@ -1545,6 +1564,21 @@ gboolean document_reload_force(GeanyDocument *doc, const gchar *forced_enc) pos = sci_get_current_position(doc->editor->sci); new_doc = document_open_file_full(doc, NULL, pos, doc->readonly, doc->file_type, forced_enc);
- if (file_prefs.keep_edit_history_on_reload && file_prefs.show_keep_edit_history_on_reload_msg)
- {
bar = document_show_message(doc, GTK_MESSAGE_INFO,on_keep_edit_history_on_reload_response,GTK_STOCK_OK, GTK_RESPONSE_ACCEPT,"Discard history", GTK_RESPONSE_NO,NULL, 0, "You can revert the buffer to the previous state "
I would be explicit "You can revert the buffer to the state before the reload"
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672/files#r41077113
@@ -1545,6 +1564,21 @@ gboolean document_reload_force(GeanyDocument *doc, const gchar *forced_enc) pos = sci_get_current_position(doc->editor->sci); new_doc = document_open_file_full(doc, NULL, pos, doc->readonly, doc->file_type, forced_enc);
- if (file_prefs.keep_edit_history_on_reload && file_prefs.show_keep_edit_history_on_reload_msg)
- {
bar = document_show_message(doc, GTK_MESSAGE_INFO,on_keep_edit_history_on_reload_response,GTK_STOCK_OK, GTK_RESPONSE_ACCEPT,"Discard history", GTK_RESPONSE_NO,NULL, 0, "You can revert the buffer to the previous state ""simply by undoing unless you choose to discard the history. ""This message will not be displayed again. "
It is traditional to have the won't repeat line last"
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672/files#r41077175
@@ -1545,6 +1564,21 @@ gboolean document_reload_force(GeanyDocument *doc, const gchar *forced_enc) pos = sci_get_current_position(doc->editor->sci); new_doc = document_open_file_full(doc, NULL, pos, doc->readonly, doc->file_type, forced_enc);
- if (file_prefs.keep_edit_history_on_reload && file_prefs.show_keep_edit_history_on_reload_msg)
- {
bar = document_show_message(doc, GTK_MESSAGE_INFO,on_keep_edit_history_on_reload_response,GTK_STOCK_OK, GTK_RESPONSE_ACCEPT,"Discard history", GTK_RESPONSE_NO,NULL, 0, "You can revert the buffer to the previous state ""simply by undoing unless you choose to discard the history. ""This message will not be displayed again. ""Your choice is can be changed in the various preferences.",
remove the "is"
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672/files#r41077467
@@ -1545,6 +1564,21 @@ gboolean document_reload_force(GeanyDocument *doc, const gchar *forced_enc) pos = sci_get_current_position(doc->editor->sci); new_doc = document_open_file_full(doc, NULL, pos, doc->readonly, doc->file_type, forced_enc);
- if (file_prefs.keep_edit_history_on_reload && file_prefs.show_keep_edit_history_on_reload_msg)
- {
bar = document_show_message(doc, GTK_MESSAGE_INFO,on_keep_edit_history_on_reload_response,GTK_STOCK_OK, GTK_RESPONSE_ACCEPT,"Discard history", GTK_RESPONSE_NO,NULL, 0, "You can revert the buffer to the previous state ""simply by undoing unless you choose to discard the history. ""This message will not be displayed again. "
Pardon?
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672/files#r41077530
@@ -1545,6 +1564,21 @@ gboolean document_reload_force(GeanyDocument *doc, const gchar *forced_enc) pos = sci_get_current_position(doc->editor->sci); new_doc = document_open_file_full(doc, NULL, pos, doc->readonly, doc->file_type, forced_enc);
- if (file_prefs.keep_edit_history_on_reload && file_prefs.show_keep_edit_history_on_reload_msg)
- {
bar = document_show_message(doc, GTK_MESSAGE_INFO,on_keep_edit_history_on_reload_response,GTK_STOCK_OK, GTK_RESPONSE_ACCEPT,"Discard history", GTK_RESPONSE_NO,NULL, 0, "You can revert the buffer to the previous state "
The message is already rather long. I'd prefer to not make it even longer without good reason.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672/files#r41077585
In general LGTM, thanks for remembering to do this.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-145181886
@@ -1545,6 +1564,21 @@ gboolean document_reload_force(GeanyDocument *doc, const gchar *forced_enc) pos = sci_get_current_position(doc->editor->sci); new_doc = document_open_file_full(doc, NULL, pos, doc->readonly, doc->file_type, forced_enc);
- if (file_prefs.keep_edit_history_on_reload && file_prefs.show_keep_edit_history_on_reload_msg)
- {
bar = document_show_message(doc, GTK_MESSAGE_INFO,on_keep_edit_history_on_reload_response,GTK_STOCK_OK, GTK_RESPONSE_ACCEPT,"Discard history", GTK_RESPONSE_NO,NULL, 0, "You can revert the buffer to the previous state "
It is one or two characters longer, but *much* more explicit.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672/files#r41078138
@@ -1545,6 +1564,21 @@ gboolean document_reload_force(GeanyDocument *doc, const gchar *forced_enc) pos = sci_get_current_position(doc->editor->sci); new_doc = document_open_file_full(doc, NULL, pos, doc->readonly, doc->file_type, forced_enc);
- if (file_prefs.keep_edit_history_on_reload && file_prefs.show_keep_edit_history_on_reload_msg)
- {
bar = document_show_message(doc, GTK_MESSAGE_INFO,on_keep_edit_history_on_reload_response,GTK_STOCK_OK, GTK_RESPONSE_ACCEPT,"Discard history", GTK_RESPONSE_NO,NULL, 0, "You can revert the buffer to the previous state "
I disagree but well, I'll change it.
But remember that this line appears in the GUI directly under the headline "The file has been reloaded." so it's sufficiently clear IMO.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672/files#r41078217
On 15-10-02 03:31 PM, Colomban Wendling wrote:
I would have tried to do it differently with a checkbox to ask whether to remember the choice, but your version seems reasonable and easy to implement. I'll have to try it for real, but it looks nice.
What does it use if not a checkbox?
It can't just show once and never again since the message can be replaced with a higher priority one (IIUC), the user might not even see it the first time, or even if they do see it, they might just want to dismiss it, to deal with it next time.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-145272642
What does it use if not a checkbox?
It can't just show once and never again since the message can be replaced with a higher priority one (IIUC), the user might not even see
it the first time, or even if they do see it, they might just want to dismiss it, to deal with it next time.
Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-145272642
It actually shows the message only once, *except* if it was replaced by a higher priority one.
So it's only shown once if the user clicked it away.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-145273953
It actually shows the message only once, *except* if it was replaced by a higher priority one. So it's only shown once if the user clicked it away.
Ok that makes more sense. What happens if the message is replaced, does it discard history or preserve it (until the next time the message is shown)?
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-145279819
The history is kept in this case (that's the default anyway)
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-145281193
I just realised that if a user ignores the info and does something else before selecting to delete history it deletes the undo for the extra things the user did.
As this is a once only notification/question, it probably should be a modal dialog to prevent any further actions until it is actioned.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-145294647
Err, no, modal is even worse for (mostly) informational messages.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-145295285
It isn't an asynchronous message, it is part of the reload action.
1. the user presses reload the first time in 1.26
2. a modal dialog comes up noting the new behaviour and offering to keep/delete history
3. user makes a selection and the dialog goes away forever and the reload completes
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-145295646
@elextr @b4n @codebrainz @frlan I'm sorry I won't manage to drive this forward until after my return from vacations. Since the string freeze is nearing again I ask that one of you pick this up and finish this up.
Or at least define a message string so that this doesn't fail again to be merged due to string freeze.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-148200931
@elextr @b4n @codebrainz @frlan string freeze on weekend, we gotta hurry.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-151518113
I personally don't like this feature nor think it should be enabled by default, and since it's one more thing I'll have to change when installing Geany, I'm certainly in no hurry myself to get it merged :)
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-151680383
@kugel- you havn't changed the message both for the change you agreed to (even if you were unsure about) and for the plain English error (unneeded "is") and you havn't added the extra commit to rename the pref.
So its you that needs to hurry :)
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-151684919
Besides that I asked someone to pick it up before my vacations, I don't feel we have worked out the final message and ui yet, therefore I did no change at all yet.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-151726177
Updated. I think I could improve the message further, I hope you agree
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-151898260
I think you mean that you *did* improve the message, and I agree thats ok.
Unless b4n objects or does it himself I'll probably commit it tomorrow.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-152107704
@@ -1545,6 +1564,21 @@ gboolean document_reload_force(GeanyDocument *doc, const gchar *forced_enc) pos = sci_get_current_position(doc->editor->sci); new_doc = document_open_file_full(doc, NULL, pos, doc->readonly, doc->file_type, forced_enc);
- if (file_prefs.keep_edit_history_on_reload && file_prefs.show_keep_edit_history_on_reload_msg)
- {
bar = document_show_message(doc, GTK_MESSAGE_INFO,on_keep_edit_history_on_reload_response,GTK_STOCK_OK, GTK_RESPONSE_ACCEPT,_("Discard history"), GTK_RESPONSE_NO,NULL, 0, _("The buffer's previous state is stored in the history. ""Undoing restores it. You can disable this by discarding the history upon ""reload. This message will not be displayed again. ""Your choice can be changed in the various preferences."),
@elextr What about
The buffer's previous state is stored in the undo history, and then file reloading can be undone. You can disable this by discarding the history upon reload. This message will not be displayed again, but your can change the behavior later in the various preference.
While I generally like short sentences, I feel like the 5 sentences here are a bit heavy to read.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672/files#r43424206
Documentation changes from https://github.com/geany/geany/commit/6f5d5db2cb6da4970aa78a64efee3a91727fea... have to also be reverted to match actual behavior
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-152273829
@@ -1545,6 +1564,21 @@ gboolean document_reload_force(GeanyDocument *doc, const gchar *forced_enc) pos = sci_get_current_position(doc->editor->sci); new_doc = document_open_file_full(doc, NULL, pos, doc->readonly, doc->file_type, forced_enc);
- if (file_prefs.keep_edit_history_on_reload && file_prefs.show_keep_edit_history_on_reload_msg)
- {
bar = document_show_message(doc, GTK_MESSAGE_INFO,on_keep_edit_history_on_reload_response,GTK_STOCK_OK, GTK_RESPONSE_ACCEPT,_("Discard history"), GTK_RESPONSE_NO,NULL, 0, _("The buffer's previous state is stored in the history. ""Undoing restores it. You can disable this by discarding the history upon ""reload. This message will not be displayed again. ""Your choice can be changed in the various preferences."),
This becomes longer again. It's already unwidely long IMO.
If the number of sentences is the problem why not just join the sentences? "The buffer's previous state is stored in the history and undoing restores it. You can disable this by discarding the history upon reload. This message will not be displayed again but your choice can be changed in the various preferences."
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672/files#r43445630
@@ -1545,6 +1564,21 @@ gboolean document_reload_force(GeanyDocument *doc, const gchar *forced_enc) pos = sci_get_current_position(doc->editor->sci); new_doc = document_open_file_full(doc, NULL, pos, doc->readonly, doc->file_type, forced_enc);
- if (file_prefs.keep_edit_history_on_reload && file_prefs.show_keep_edit_history_on_reload_msg)
- {
bar = document_show_message(doc, GTK_MESSAGE_INFO,on_keep_edit_history_on_reload_response,GTK_STOCK_OK, GTK_RESPONSE_ACCEPT,_("Discard history"), GTK_RESPONSE_NO,NULL, 0, _("The buffer's previous state is stored in the history. ""Undoing restores it. You can disable this by discarding the history upon ""reload. This message will not be displayed again. ""Your choice can be changed in the various preferences."),
Well, okay, although I don't really see much difference in length, it sounds good enough your way just removing the two stops.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672/files#r43451117
@@ -1545,6 +1564,21 @@ gboolean document_reload_force(GeanyDocument *doc, const gchar *forced_enc) pos = sci_get_current_position(doc->editor->sci); new_doc = document_open_file_full(doc, NULL, pos, doc->readonly, doc->file_type, forced_enc);
- if (file_prefs.keep_edit_history_on_reload && file_prefs.show_keep_edit_history_on_reload_msg)
- {
bar = document_show_message(doc, GTK_MESSAGE_INFO,on_keep_edit_history_on_reload_response,GTK_STOCK_OK, GTK_RESPONSE_ACCEPT,_("Discard history"), GTK_RESPONSE_NO,NULL, 0, _("The buffer's previous state is stored in the history. ""Undoing restores it. You can disable this by discarding the history upon ""reload. This message will not be displayed again. ""Your choice can be changed in the various preferences."),
Might be useful to add the name of the various preference so user doesn't have to hunt for it or try/test different preferences.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672/files#r43460881
We should probably also add a note in the docs warning about using this option with large files, since it will "leak" any reloaded documents for the entire document's lifetime. I can just imagine someone filing a bug about "Geany leaks hundreds of megabytes when I reload many large files after changed on disk" or stuff like that.
Are we definitively sure this should be enabled by default? (I'm not :)
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-152364053
@b4n fixed your remarks
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-152541459
We should probably also add a note in the docs warning about using this option with large files, since it will "leak" any reloaded documents for the entire document's lifetime. I can just imagine someone filing a bug about "Geany leaks hundreds of megabytes when I reload many large files after changed on disk" or stuff like that.
Are we definitively sure this should be enabled by default? (I'm not :)
Well… I think it's a very nice feature; but OTOH you're right that until (unless?) Scintilla starts to store a diff in the history instead of the whole change (or we do), it'll use a largish amount of memory. And it seems very possible most people tend to reload mostly largish files (logs, DB dumps or whatnot generated outside and getting updated), so it might have a larger impact than on other features. However, closing the document releases the memory, so it "only" impacts while the document is in use.
I guess ideally we'd reduce the memory impact the feature has, but until then I'm not 100% certain.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-152656013
Otherwise LGTM
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-152656166
The feature was initially accepted with default = on, so unless there are actual problems I don't see an evidence to keep the off default.
I think it's a nice and convinient feature which should be on ultimately on by default. its memory consumption is a detail and can be fixed elsewhere (if it's even necessary)
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-152657813
String freeze is tomorrow so please merge
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-152667840
@b4n, don't punish the innocent (those who will use the feature as intended) just because somebody *might* use it wrong.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-152670356
@elextr fair enough for me. Could you please review the string one last time and merge this? Don't forget to close #562 in the merge commit
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-152677604
Merged #672.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#event-450983164
[...] so unless there are actual problems I don't see an evidence to keep the off default.
I mentioned a number of issues with it in the mailing list thread linked from the PR you made to disable it by default.
I don't think we should cram this in just because of string freeze, especially with the open issues, the UI issues, and that we will be releasing again in a few months. I'm not opposed to the feature, I'm opposed to the implementation (re-using an existing feature to do something else, something unexpected of the existing feature, as well as the infobar without a checkbox that can be hidden from the user without ever seeing it).
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-152685983
Bummer ... I think we should reconsider enabling this feature by default, or at the very least fix the issues with it.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-152686209
Am 31. Oktober 2015 02:52:01 MEZ, schrieb Matthew Brush notifications@github.com:
[...] so unless there are actual problems I don't see an evidence to
keep the off default.
I mentioned a number of issues with it in the mailing list thread linked from the PR you made to disable it by default.
I don't think we should cram this in just because of string freeze, especially with the open issues, the UI issues, and that we will be releasing again in a few months. I'm not opposed to the feature, I'm opposed to the implementation (re-using an existing feature to do something else, something unexpected of the existing feature, as well as the infobar without a checkbox that can be hidden from the user without ever seeing it).
Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-152685983
Carrying this discussion to the ML.
Can you elaborate on the issues you see?
As to the UI. It's important that we get any UI for 1.26, therefore we had to manage before string freeze. We can introduce a better UI fir 1.27. I'm not opposed to a check box but would be more effort. And it would presumably checked by default anyway, no?
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/672#issuecomment-152716953
github-comments@lists.geany.org