You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1352
-- Commit Summary --
* Windows: Compile GLib schemas after installation
-- File Changes --
M build/geany-plugins.nsi (2) M build/gtk-bundle-from-msys2.sh (1)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/1352.patch https://github.com/geany/geany-plugins/pull/1352.diff
@b4n commented on this pull request.
@@ -152,6 +152,8 @@ Section "Dependencies" SEC04
SectionEnd
Section -Post + Exec '"$INSTDIR\bin\glib-compile-schemas.exe" "$INSTDIR\share\glib-2.0\schemas"'
How does this behave if the executable is missing? If it is mandatory, then maybe mark the dependency somehow? Also, has `$INSTDIR` has to be the same as Geany's? If not, we won't find the executable here, will we?
@b4n commented on this pull request.
@@ -152,6 +152,8 @@ Section "Dependencies" SEC04
SectionEnd
Section -Post + Exec '"$INSTDIR\bin\glib-compile-schemas.exe" "$INSTDIR\share\glib-2.0\schemas"'
Do we need to re-run this on uninstall to "de-compile" the uninstalled schemas?
@eht16 commented on this pull request.
@@ -152,6 +152,8 @@ Section "Dependencies" SEC04
SectionEnd
Section -Post + Exec '"$INSTDIR\bin\glib-compile-schemas.exe" "$INSTDIR\share\glib-2.0\schemas"'
How does this behave if the executable is missing? If it is mandatory, then maybe mark the dependency somehow?
Not sure, I'll test this. We could add the GLib package to the plugins bundle, it would be redundant to the one in the Geany bundle but probably won't hurt.
Also, has `$INSTDIR` has to be the same as Geany's? If not, we won't find the executable here, will we?
True. But much more things won't work then, the compiled schemas will probably only searched in Geany's installation directory. Using another installation directory for G-P doesn't make much sense at all.
Do we need to re-run this on uninstall to "de-compile" the uninstalled schemas?
In theory, yes. In reality, we do not uninstall the installed schema files. To do so, we had to track each installed file to know what to uninstall. This would be nice but also quite some work.
@b4n commented on this pull request.
@@ -152,6 +152,8 @@ Section "Dependencies" SEC04
SectionEnd
Section -Post + Exec '"$INSTDIR\bin\glib-compile-schemas.exe" "$INSTDIR\share\glib-2.0\schemas"'
OK. If `$INSTDIR` ought to be the same, maybe just make the 2.1 installer depend on Geany 2.1's one and call it a day.
@eht16 pushed 1 commit.
5298197dbef2ae5ac5047d461aa521b8b32406c4 Windows: Make installer depend on Geany 2.1
@eht16 commented on this pull request.
@@ -152,6 +152,8 @@ Section "Dependencies" SEC04
SectionEnd
Section -Post + Exec '"$INSTDIR\bin\glib-compile-schemas.exe" "$INSTDIR\share\glib-2.0\schemas"'
OK. If `$INSTDIR` ought to be the same, maybe just make the 2.1 installer depend on Geany 2.1's one and call it a day.
Good point, done.
How does this behave if the executable is missing? If it is mandatory, then maybe mark the dependency somehow?
Not sure, I'll test this. We could add the GLib package to the
Tested: the installer silently ignores a missing "glib-compile-schemas". In this case, this is good I'd say.
@b4n commented on this pull request.
@@ -152,6 +152,8 @@ Section "Dependencies" SEC04
SectionEnd
Section -Post + Exec '"$INSTDIR\bin\glib-compile-schemas.exe" "$INSTDIR\share\glib-2.0\schemas"'
Ok yeah it's probably at least good enough.
@b4n approved this pull request.
LGTM
Merged #1352 into master.
github-comments@lists.geany.org