@eht16 commented on this pull request.


In build/geany-plugins.nsi:

> @@ -152,6 +152,8 @@ Section "Dependencies" SEC04
 SectionEnd
 
 Section -Post
+	Exec '"$INSTDIR\bin\glib-compile-schemas.exe" "$INSTDIR\share\glib-2.0\schemas"'

OK. If $INSTDIR ought to be the same, maybe just make the 2.1 installer depend on Geany 2.1's one and call it a day.

Good point, done.

How does this behave if the executable is missing? If it is mandatory, then maybe mark the dependency somehow?

Not sure, I'll test this. We could add the GLib package to the

Tested: the installer silently ignores a missing "glib-compile-schemas". In this case, this is good I'd say.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany-plugins/pull/1352/review/2079589672@github.com>