@eht16 commented on this pull request.


In build/geany-plugins.nsi:

> @@ -152,6 +152,8 @@ Section "Dependencies" SEC04
 SectionEnd
 
 Section -Post
+	Exec '"$INSTDIR\bin\glib-compile-schemas.exe" "$INSTDIR\share\glib-2.0\schemas"'

How does this behave if the executable is missing? If it is mandatory, then maybe mark the dependency somehow?

Not sure, I'll test this.
We could add the GLib package to the plugins bundle, it would be redundant to the one in the Geany bundle but probably won't hurt.

Also, has $INSTDIR has to be the same as Geany's? If not, we won't find the executable here, will we?

True. But much more things won't work then, the compiled schemas will probably only searched in Geany's installation directory. Using another installation directory for G-P doesn't make much sense at all.

Do we need to re-run this on uninstall to "de-compile" the uninstalled schemas?

In theory, yes. In reality, we do not uninstall the installed schema files. To do so, we had to track each installed file to know what to uninstall.
This would be nice but also quite some work.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany-plugins/pull/1352/review/2079029781@github.com>