Force push to include "GeanyLua" in the commit log.

@xiota Try [/util/mkiface.lua](https://github.com/geany/geany-plugins/blob/master/geanylua/util/mkiface.lua).

@elextr

need to map Lexilla as well as Scintilla

Why? GeanyLua uses the Scintilla interface, also all SCI_*LEXER* will be available.

Even if it could be added, `setilexer` probably shouldn't, if a plugin sets a lexer directly it is likely to break lots of filetype things that depend on the known lexer, set the filetype via Geany which will set the appropriate lexer, not the lexer directly.

@xiota pushed 1 commit.

febc7dd6bd2b6106844d1563af66eafe9be61481 GeanyLua: Use util/mkiface.lua to generate new glspi_sci.h

@xiota if a plugin modifies _any_ Scintilla/Lexilla or other setting that Geany uses it can upset how Geany uses it, or the value the plugin sets could be overwritten by Geany at any point, possibly breaking the plugin. Geany simply does not know about what plugins do outside the documented plugin API. And what and how Geany uses Scintilla/Lexilla can change at any time. Plugins are not supposed to use anything not part of the [documented plugin API](https://www.geany.org/manual/reference/), and direct interaction with Scintilla isn't in that set.

But catching signals is fine, its what you do when you get it that matters. :smile:

Ultimately the Geany devs only advise plugin writers, we are not responsible for plugin content, just the collection infrastructure. So long as the plugin doesn't crash Geany its normally up to the plugin maintainer, but as the plugin is orphaned, I guess its up to you if you want to pass the risk on to Lua writers or not.

@elextr I think, all ```SCI_*LEXER*``` are not really needed in this plugin (so they can stay in this list and no more), also you wrote

You should not set the lexer directly, set the Geany filetype instead.

[here](https://github.com/geany/geany-plugins/issues/646). Now we can get the current filetype ```lua local finfo = geany.fileinfo() if finfo ~= nil then geany.message('Current filetype is "' .. finfo.type .. '": ' .. finfo.desc) end ``` and it may be useful to change the current filetype: something like ```geany.settype(".cmake")``` with ```c /* Change the current file type by the specified file extension */ static gint glspi_set_filetype(lua_State* L) { GeanyDocument *doc=NULL; GeanyFiletype *ft=NULL; const gchar *ftn=NULL;

if (lua_gettop(L)==1){ if (!lua_isstring(L, 1)) { return FAIL_STRING_ARG(1); } doc = document_get_current(); if (!(doc && doc->is_valid)) { return 0; } ftn=lua_tostring(L, 1); if ('\0' == ftn[0]) { return 0; } ft=filetypes_detect_from_extension(ftn); if (ft != NULL){ document_set_filetype(doc, ft); return 1; } } return 0; } ``` in ```glspi_doc.c```. But currently ```filetypes_detect_from_extension``` is not a prt of Geany API.

@elextr yes, of course, I don't know what I thought about :) Fixed. I think I will wait when the @xiota's PRs will be merged.

@elextr I'd like to nominate @Skif-off, if he's willing, to be GeanyLua maintainer because...

* He's made multiple contributions to GeanyLua in the past. * He appears to have ongoing interest in GeanyLua. * He's responsive to GitHub messages.

Someone nominates themselves as maintainer by providing a PR adding their details to the `MAINTAINERS` file for the relevant plugin and doing so also indicates that they are willing to take responsibility for the whole plugin, not just their own PRs, so nobody can be nominated against their wishes.

@Skif-off @xiota For geanylua PRs why don't you review and test each others PRs, at least both of you both know Lua. I wouldn't know Lua from the moon :drum: :drum: and I don't use Geanylua so it will never get tested unless I spend time specifically on it, and I don't have that ATM. (Geany PRs, like the Scintilla upgrade, are getting tested whenever I have Geany open so "testing" does not take time away from other things, but I don't regularly use plugins.)

@xiota and @Skif-off: I agree with @elextr: reviewing your changes each other is a good idea. I'm in the same situation as @elextr (and probably all other regular contributors), I don't know Lua and I don't use the plugin. So testing and reviewing is too hard. Given the fact that the plugin doesn't build at all right now and that maybe most of the plugin's users reading this post, I think we can go for it once you agree on the changes.

Any news? New Scintilla/Lexilla in upstream now.

@Skif-off Thanks for the reminder. I've been feeling like I've been forgetting something.

The only change is to regenerate `glspi_sci.h`. The only script I have that sends scintilla messages still works: ```Lua geany.scintilla ("SCI_SETEDGEMODE", 3, 3) geany.scintilla ("SCI_MULTIEDGECLEARALL", 0, 0)

-- Colors are in BGR order geany.scintilla ("SCI_MULTIEDGEADDLINE", 60, 0xe5e5e5) geany.scintilla ("SCI_MULTIEDGEADDLINE", 72, 0xffd0b0) -- blue geany.scintilla ("SCI_MULTIEDGEADDLINE", 80, 0xffc0ff) -- purple geany.scintilla ("SCI_MULTIEDGEADDLINE", 88, 0xe5e5e5) geany.scintilla ("SCI_MULTIEDGEADDLINE", 96, 0xa0b0ff) -- red geany.scintilla ("SCI_MULTIEDGEADDLINE", 104, 0xe5e5e5) geany.scintilla ("SCI_MULTIEDGEADDLINE", 112, 0xe5e5e5) geany.scintilla ("SCI_MULTIEDGEADDLINE", 120, 0xe5e5e5) geany.scintilla ("SCI_MULTIEDGEADDLINE", 128, 0xe5e5e5) geany.scintilla ("SCI_MULTIEDGEADDLINE", 136, 0xe5e5e5) geany.scintilla ("SCI_MULTIEDGEADDLINE", 144, 0xe5e5e5) geany.scintilla ("SCI_MULTIEDGEADDLINE", 152, 0xe5e5e5) geany.scintilla ("SCI_MULTIEDGEADDLINE", 160, 0xe5e5e5) ```

@Skif-off Can you let me know whether you'll be able to do a code review on this? Thanks.

@Skif-off... Thanks for looking and testing.

@eht16 and @elextr had requested that we review each other's PRs, and it doesn't hurt to have extra eyes.

I just saw geany/geany#3046... So it may be yet longer before this can be merged ☹️

GeanyLua might remain a little broken but the rest of G-P will compile again.

We could always switch the default for Geany lua to disable until its fixed so everything else works in the meantime.

@eht16

updating this PR shortly (if possible) after [geany/geany#3046](https://github.com/geany/geany/pull/3046) is merged

As I see, [geany/geany#3046](https://github.com/geany/geany/pull/3046) does not contain changes that matter for this plugin (in this case GeanyLua uses only ```Scintilla.h``` and ```Scintilla.iface```).

Original code for `glspi_scintilla()` has: * some check for when missing arguments are allowed * switch for wparam * near-identical switch for lparam * switch for result

Changes: * Removed extraneous nested parentheses from the parameter check for missing arguments. * Added switch to ignore some lexer messages because lexilla is now separate from scintilla. It was [pointed out](https://github.com/geany/geany-plugins/pull/1123#issuecomment-947310520) that messing with the lexer could cause problems elsewhere in Geany. * Combined the near identical argument-handling switch statements into a static function. The number of scintilla types went from ~10 to ~70. Keeping the switches separate could lead to potentially difficult to track problems if they go out of sync. * Added new types to the result switch. Basically treating most types as int. This can be shuffled around later, as needed.

Merged #1123 into master.