Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
@Skif-off true, the #3046 does not change the generated gsdlg.h and also don't contain any other obvious changes which are related. So this PR is independent of the pending Scintilla update.
It doesn't look bad, I just did not yet understand why the many parameter handling changes are necessary.
The commit message of b0b1b2a is not very verbose. I see there are new parameter types added but also some existing code moved and so potential logic changed. This is probably ok, I just cannot see why.
@xiota can you shed some light on this?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.