Original code for glspi_scintilla()
has:
- some check for when missing arguments are allowed
- switch for wparam
- near-identical switch for lparam
- switch for result
Changes:
- Removed extraneous nested parentheses from the parameter check for missing arguments.
- Added switch to ignore some lexer messages because lexilla is now separate from scintilla. It was pointed out that messing with the lexer could cause problems elsewhere in Geany.
- Combined the near identical argument-handling switch statements into a static function. The number of scintilla types went from ~10 to ~70. Keeping the switches separate could lead to potentially difficult to track problems if they go out of sync.
- Added new types to the result switch. Basically treating most types as int. This can be shuffled around later, as needed.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany-plugins/pull/1123/c1003777174@github.com>