codebrainz commented on this pull request.
> @@ -53,6 +53,8 @@ public void plugin_init(Geany.Data data)
Alignment align;
MultiTerm.Notebook notebook;
+ toplevel_widgets = new List<Widget>();
This probably needs to be assigned `null` in the cleanup function to avoid a leak in the GC and so there's no dangling junk left in it.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/95#pullrequestreview-261009125
codebrainz commented on this pull request.
> @@ -149,7 +153,11 @@ namespace MultiTerm
context_menu.new_window_activate.connect(on_new_window_activate);
context_menu.move_to_location_activate.connect(on_move_to_location);
}
+#if MULTITERM_GTK3
+ context_menu.popup_at_pointer(event);
Not for compile-time versions (ie. `GTK_CHECK_VERSION` macros), Vala's preprocessor is too wimpy. You can pass along a macro from the build system using `-D` option if it's really needed.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/95#discussion_r302785044
codebrainz commented on this pull request.
> @@ -68,6 +68,20 @@ namespace MultiTerm
item.show();
}
+ private Gtk.MenuItem add_image_menu_item(string label_text, string icon_name)
Yeah, just prevents some warnings from the Vala compiler because it would be unused.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/95#discussion_r302777889
@codebrainz: Hmmm...I can now at least build your repo but if I open the plugin manager I do not see the Multiterm plugin (already did a ```ldconfig /usr/local/lib```).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/95#issuecomment-510634696
@LarsGit223 pushed 1 commit.
6d467b9a04d6c77a7ed38a01b58bc1b8e7c6d9d7 multiterm: fixed 'error: Non-constant field initializers not supported in this context'
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany-plugins/pull/95/files/8b281acfa088615fda62c0…
@LarsGit223 pushed 1 commit.
8b281acfa088615fda62c0c7bc8b0a4ab831e06e multiterm: fixed 'warning: the modifier `static' is not applicable to constants'
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany-plugins/pull/95/files/5035fe7097a1aff8c9c52a…
LarsGit223 commented on this pull request.
> @@ -149,7 +153,11 @@ namespace MultiTerm
context_menu.new_window_activate.connect(on_new_window_activate);
context_menu.move_to_location_activate.connect(on_move_to_location);
}
+#if MULTITERM_GTK3
+ context_menu.popup_at_pointer(event);
Can I use normal gtk C-style version checks in valac?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/95#discussion_r302703239
LarsGit223 commented on this pull request.
> @@ -68,6 +68,20 @@ namespace MultiTerm
item.show();
}
+ private Gtk.MenuItem add_image_menu_item(string label_text, string icon_name)
Done. Even if not it shouldn't be callable on gtk2.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/95#discussion_r302703058
@LarsGit223 pushed 1 commit.
5035fe7097a1aff8c9c52acafe1defe38c439129 multiterm: function 'add_image_menu_item()' should only exist on gtk3
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany-plugins/pull/95/files/d021abc54e2bf0522d159d…