LarsGit223 commented on this pull request.
> @@ -149,7 +153,11 @@ namespace MultiTerm
context_menu.new_window_activate.connect(on_new_window_activate);
context_menu.move_to_location_activate.connect(on_move_to_location);
}
+#if MULTITERM_GTK3
+ context_menu.popup_at_pointer(event);
Can I use normal gtk C-style version checks in valac?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/95#discussion_r302703239
LarsGit223 commented on this pull request.
> @@ -68,6 +68,20 @@ namespace MultiTerm
item.show();
}
+ private Gtk.MenuItem add_image_menu_item(string label_text, string icon_name)
Done. Even if not it shouldn't be callable on gtk2.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/95#discussion_r302703058
@LarsGit223 pushed 1 commit.
5035fe7097a1aff8c9c52acafe1defe38c439129 multiterm: function 'add_image_menu_item()' should only exist on gtk3
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany-plugins/pull/95/files/d021abc54e2bf0522d159d…
b4n commented on this pull request.
Looks fine
> @@ -383,6 +381,10 @@ GeanyDocument *document_get_current(void)
void document_init_doclist(void)
{
documents_array = g_ptr_array_new();
+#ifdef GEANY_DEBUG
+ // add a dummy invalid document to catch naive iteration
+ g_ptr_array_add(documents_array, g_new0(GeanyDocument, 1));
If I'm not mistaken you could simply use `new_doc_index()` now
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/247#pullrequestreview-252108943
The feature lets the user search for projects to add them to the Workbench. After selecting the menu item, the user can select a directory to search through. The directory and it's sub-directories are scanned for project files (```*.geany```). All found files are listed and after scanning is done the user can select the projects which shall be added to the Workbench.
The dialog is not modal - the user can do other work during the scanning of the directory.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/875
-- Commit Summary --
* workbench: added new feature "Search projects"
-- File Changes --
M workbench/README (6)
M workbench/src/Makefile.am (2)
M workbench/src/menu.c (29)
M workbench/src/menu.h (1)
M workbench/src/plugin_main.c (2)
A workbench/src/search_projects.c (537)
A workbench/src/search_projects.h (24)
M workbench/src/sidebar.c (3)
M workbench/src/workbench.c (6)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/875.patchhttps://github.com/geany/geany-plugins/pull/875.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/875
codebrainz commented on this pull request.
> @@ -149,7 +153,11 @@ namespace MultiTerm
context_menu.new_window_activate.connect(on_new_window_activate);
context_menu.move_to_location_activate.connect(on_move_to_location);
}
+#if MULTITERM_GTK3
+ context_menu.popup_at_pointer(event);
This requires GTK+ 3.22 but I think the build system only checks for GTK+ >= 3.0, so if someone built it with any version of GTK+ between 3.0 and 3.22, it would cause a build error.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/95#pullrequestreview-259199360
codebrainz commented on this pull request.
> @@ -68,6 +68,20 @@ namespace MultiTerm
item.show();
}
+ private Gtk.MenuItem add_image_menu_item(string label_text, string icon_name)
I guess this should be guarded with `#if MULTITERM_GTK3` too? IIRC Vala compiler warns about unused private functions.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/95#pullrequestreview-259197098
I do coding in virtualenv and at present I access my virtualenv in VTE using `virutalenvwrapper` with the command `workon ENV`. Instead of this I want to directly load the virtualenv bash in VTE everytime I open geany. I know how to get the virtualenv's python but its the bash I am after. I tried changing `Edit > Preference > Terminal > Shell` to `workon ENV` from `/bin/bash` which doesn't work. I also tried to source directly `source ENV/bin/activate` which also doesn't work. How do we enablel virtualenv bash in VTE?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2210