For some .js files the symbols browser is empty.
No symbols:
Symbols appear when I comment-out some js code:
Presented file is from Froala editor : https://github.com/froala/wysiwyg-editor
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1329
```javascript
async function test(a,b)
{
console.log(a+b);
}
function test_missing(a,b)
{
console.log(a+b);
}
```
As soon as one function is declared as async
the parser breaks and the symbollist does not show any more functions
Might be solved with
https://github.com/universal-ctags/ctags/pull/1544
but patching Release failed 1.33
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1933
elextr commented on this pull request.
> @@ -675,6 +682,45 @@ const gchar *vte_get_working_directory(void)
g_free(cwd);
}
}
+ else
+ {
+ gint status = 0;
+ gchar *stdout = NULL;
+ gchar *pid_str = g_strdup_printf("%d", pid);
+ gchar *argv[] = {"lsof", "-a", "-d", "cwd", "-F", "n", "-p", pid_str, NULL};
Note the `exec` family of system calls takes `char* const argv[]` so `g_spawn` is looser than needed.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/436#discussion_r279191981
elextr commented on this pull request.
> @@ -675,6 +682,45 @@ const gchar *vte_get_working_directory(void)
g_free(cwd);
}
}
+ else
+ {
+ gint status = 0;
+ gchar *stdout = NULL;
+ gchar *pid_str = g_strdup_printf("%d", pid);
+ gchar *argv[] = {"lsof", "-a", "-d", "cwd", "-F", "n", "-p", pid_str, NULL};
`utils_spawn_sync` calls `spawn_sync` which on Linux eventually calls `g_spawn_async` which specifies the array as `gchar**`, not a `const` in sight, so it may be a pain to try to `const`ize this.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/436#discussion_r279191902
See: https://github.com/universal-ctags/ctags/pull/2084
This import has 3 difference with upstream:
* don't use newer API than current Geany has (will be fixed by a later sync, maybe #2132 already);
* workaround a current limitation of our ctags use to emit tags for a kind disabled by default (should be fixed in #2132);
* workaround a current limitation of our ctags use to emit reference tags.
They are fairly small differences, and they should alight with further sync.
---
reviewers, won't wait too long, I'll merge soon ;)
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2134
-- Commit Summary --
* Add new upstream candidate Flex parser
-- File Changes --
M ctags/Makefile.am (2)
M ctags/main/parsers.h (2)
D ctags/parsers/actionscript.c (99)
A ctags/parsers/flex.c (2636)
M src/symbols.c (1)
M src/tagmanager/tm_parser.c (15)
M tests/ctags/Makefile.am (7)
A tests/ctags/actionscript/as-first-token.as (1)
A tests/ctags/actionscript/as-first-token.as.tags (2)
A tests/ctags/actionscript/classes.as (16)
A tests/ctags/actionscript/classes.as.tags (13)
A tests/ctags/actionscript/const.as (8)
A tests/ctags/actionscript/const.as.tags (6)
A tests/ctags/actionscript/const2.as (7)
A tests/ctags/actionscript/const2.as.tags (3)
A tests/ctags/actionscript/method-attributes.as (12)
A tests/ctags/actionscript/method-attributes.as.tags (10)
A tests/ctags/actionscript/packages.as (9)
A tests/ctags/actionscript/packages.as.tags (7)
A tests/ctags/actionscript/sampler.as (66)
A tests/ctags/actionscript/sampler.as.tags (16)
-- Patch Links --
https://github.com/geany/geany/pull/2134.patchhttps://github.com/geany/geany/pull/2134.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2134
b4n requested changes on this pull request.
Looks good apart the comment, although I didn't actually test it on anything but my Linux :)
> @@ -675,6 +682,45 @@ const gchar *vte_get_working_directory(void)
g_free(cwd);
}
}
+ else
+ {
+ gint status = 0;
+ gchar *stdout = NULL;
+ gchar *pid_str = g_strdup_printf("%d", pid);
+ gchar *argv[] = {"lsof", "-a", "-d", "cwd", "-F", "n", "-p", pid_str, NULL};
Ideally you'd make this a `const gchar*` array, so that literals can be constant; and in the call below just cast up to `gchar**`.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/436#pullrequestreview-231457053
I have Geany 1.33 installed on Windows 10.
When I copy text in Geany via context menu and paste it in Geany, it works.
When I copy text in Geany via ctrl-c and paste it in Geany, it works.
When I copy text in Geany via context menu and paste it outside of Geany, it works.
When I copy text in Geany via ctrl-c and paste it outside of Geany, it DOESN'T always work.
I didn't experience this behavior with any other application installed on my Windows 10 system.
I also didn't experience this behavior with a Xubuntu system I'm using.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1971