I've just ran the script to generate an up2date php.tags file and then squashed the commits together in case we want to merge it.
It would have been cool if we got any feedback from some PHP users in #584. After my quick tests the new list is better but I don't know PHP well enough to really judge.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/603#issuecomment-192831458
Yup, `gtk_menu_shell_insert(menubar, menu_vc, g_list_length(gtk_container_get_children(menubar)) - 1);` would work.
But as said, this is just cosmetics. If you have time, I guess @frlan would merge a PR happily or even fix it himself :).
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/commit/c6a7968d5ab71961db4b0a5e721d3…
Yup, `gtk_menu_shell_insert(menubar, menu_vc, g_list_length(gtk_container_get_children(menubar)) - 1);` would work.
But as said, this is just cosmetics. If you have time, I guess @frlan would merge a PR happily or even fix it himself :).
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/commit/c6a7968d5ab71961db4b0a5e721d3…
Accessing `menubar->children` doesn't work in Gtk3. I thought using _append instead of _insert would be equivalent, but apperently it's an off-by-one. I guess `gtk_menu_shell_insert(menubar, menu_vc, g_list_length(gtk_container_get_children() - 1))` is more appropriate?
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/commit/c6a7968d5ab71961db4b0a5e721d3…
Just out of curiosity: what was the reason for this change?
Checking the API docs, `gtk_menu_shell_insert` does not seem deprecated or anything.
This change caused a slight behavioural change: the VC menu bar item is now appended, i.e. after the `Help` menu item and not before. Not that this anything important, just a bit cosmetics.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/commit/c6a7968d5ab71961db4b0a5e721d3…
In fact the filtered_tags->len > 0 check shouldn't be necessary as in the case when last_tag == NULL the tag gets inserted in the else below - but better to make it more explicit.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/commit/c84c41e44a69727a51abebf58936b65bd8065…