Yup, `gtk_menu_shell_insert(menubar, menu_vc, g_list_length(gtk_container_get_children(menubar)) - 1);` would work.
But as said, this is just cosmetics. If you have time, I guess @frlan would merge a PR happily or even fix it himself :).
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/commit/c6a7968d5ab71961db4b0a5e721d3…
Yup, `gtk_menu_shell_insert(menubar, menu_vc, g_list_length(gtk_container_get_children(menubar)) - 1);` would work.
But as said, this is just cosmetics. If you have time, I guess @frlan would merge a PR happily or even fix it himself :).
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/commit/c6a7968d5ab71961db4b0a5e721d3…
Accessing `menubar->children` doesn't work in Gtk3. I thought using _append instead of _insert would be equivalent, but apperently it's an off-by-one. I guess `gtk_menu_shell_insert(menubar, menu_vc, g_list_length(gtk_container_get_children() - 1))` is more appropriate?
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/commit/c6a7968d5ab71961db4b0a5e721d3…
Just out of curiosity: what was the reason for this change?
Checking the API docs, `gtk_menu_shell_insert` does not seem deprecated or anything.
This change caused a slight behavioural change: the VC menu bar item is now appended, i.e. after the `Help` menu item and not before. Not that this anything important, just a bit cosmetics.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/commit/c6a7968d5ab71961db4b0a5e721d3…
In fact the filtered_tags->len > 0 check shouldn't be necessary as in the case when last_tag == NULL the tag gets inserted in the else below - but better to make it more explicit.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/commit/c84c41e44a69727a51abebf58936b65bd8065…
This turns messages like:
```
** INFO: User plugins: /home/enrico/tmp/geany_conf/plugins/geanypy/plugins
** INFO: System plugins: /home/enrico/apps/share/geany/geanypy/plugins
```
into
```
GeanyPy-INFO: User plugins: /home/enrico/tmp/geany_conf/plugins/geanypy/plugins
GeanyPy-INFO: System plugins: /home/enrico/apps/share/geany/geanypy/plugins
```
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/371
-- Commit Summary --
* Set G_LOG_DOMAIN for proper GLib error reporting/logging
-- File Changes --
M geanypy/src/Makefile.am (3)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/371.patchhttps://github.com/geany/geany-plugins/pull/371.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/371
These are some patches related to the scope completion patch set:
1. The first patch is the scope completion for namespaces.
2. Then there's a patch using the langs_compatible() function for scintilla type colorization - this is a prerequisite of https://github.com/geany/geany/pull/857
3. When working on the above patch I noticed that the -1/-2 language type codes are a bit confusing and not used correctly in the function so I tried to clean it up a bit and fix things.
4. When testing scope completion for boost I noticed there are many tags with identical names (probably because of inheritance). Just one tag of the given name can be passed to Scintilla for tag colorization to improve performance a bit.
5. The very last patch is a suggestion but I can remove it if you find it too intrusive.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/906
-- Commit Summary --
* Add scope completion for namespaces
* Cleanup NONE/AUTO filetype definitions
* Use the langs_compatible() function when passing typenames to scintilla
* Don't pass multiple copies of identical type name to scintilla for colorization
* Don't use ctags types inside Geany
-- File Changes --
M src/editor.c (12)
M src/filetypes.c (2)
M src/filetypes.h (8)
M src/symbols.c (10)
M tagmanager/src/tm_parser.h (14)
M tagmanager/src/tm_source_file.c (23)
M tagmanager/src/tm_source_file.h (12)
M tagmanager/src/tm_tag.c (22)
M tagmanager/src/tm_tag.h (8)
M tagmanager/src/tm_workspace.c (108)
M tagmanager/src/tm_workspace.h (8)
-- Patch Links --
https://github.com/geany/geany/pull/906.patchhttps://github.com/geany/geany/pull/906.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/906