After the filetype_id change I went through the Geany headers to check if other types use some strange naming convention and noticed this one (and no guarantees I didn't miss many others). Not that the rename really matters because it's not part of the API and isn't almost used but well, here it is...
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/933
-- Commit Summary --
* Rename socket_info_struct to SocketInfo
-- File Changes --
M src/socket.c (2)
M src/socket.h (4)
-- Patch Links --
https://github.com/geany/geany/pull/933.patchhttps://github.com/geany/geany/pull/933.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/933
It might miss the header `# format=tagmanager`, which is useful to avoid guessing the format. Will check later if nobody beats me to it
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/603#issuecomment-192902532
@eht16 IIRC when I tested and provided improvements, I saw it was pretty good, but missed a few things (i.e. the `mysqli_affected_rows` thing), but it wasn't our fault but an improper source. Maybe they fixed it, I don't know.
IMO it's fine to merge, we can always improve it later on.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/603#issuecomment-192900580
To encourage making "proper" prefs that users can find, instead of "various" prefs that nobody sees, the HACKING should point to the stash docs in the plugin API.
Will make PR "soon" if nobody beats me to it.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/919
I've just ran the script to generate an up2date php.tags file and then squashed the commits together in case we want to merge it.
It would have been cool if we got any feedback from some PHP users in #584. After my quick tests the new list is better but I don't know PHP well enough to really judge.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/603#issuecomment-192831458