Thanks for the reminder of #789.
Actually I searched this morning (UTC) for a recent version of grep for Windows but didn't find anything. So I ended up again with grep from UnxUtils but this time a slightly newer version (2.5.1) than the version 2.4 we shipped with Geany 1.26. That newer version of grep has the `--include` option so it should be ok, still it's very old.
Another option would be `grep` from MSYS2, but it would also require to ship some runtime libraries of MSYS2 as dependencies.
@codebrainz in #789 you said, you built your own `grep` binary. Is building `grep` hard and/or would be the binary suitable for distribution?
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/560#issuecomment-193009365
@eht16 remember the bug about old-timey grep in #789 not supporting the needed features. The UnxUtils one appears to be from 2003.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/560#issuecomment-192982324
Same as #931 but using a typedef. Also, there's no conflict.
@kugel- I fixed the GtkDoc header generation script not to break if a typedef type contains a reference. However, will the alias `filetype_id` confuse GIR or not?
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/932
-- Commit Summary --
* Replace filetype_id with GeanyFiletypeID
* Deprecate filetype_id in favor of GeanyFiletypeID
* Fix GtkDoc header generation script to handle references inside typedef
-- File Changes --
M scripts/gen-api-gtkdoc.py (2)
M src/filetypes.c (8)
M src/filetypes.h (5)
M src/symbols.c (8)
-- Patch Links --
https://github.com/geany/geany/pull/932.patchhttps://github.com/geany/geany/pull/932.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/932
Since the new spawn API, which is used by utils_spawn_sync() as well,
passing a whole command line in argv[0] doesn't work any longer.
So use the new spawn API directly which conveniently offers to
pass the command either as command line or as argv.
Tested on Linux and Windows.
I bumped the required API version. It seems unfortunately we didn't bump the API version in Geany when merging the spawn API but the currently used 226 is newer than the spawn API and is already available in the last Geany release, so it should be ok.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/372
-- Commit Summary --
* Use new spawn API to fix broken Win32 ctags.exe command execution
-- File Changes --
M geanyctags/src/geanyctags.c (24)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/372.patchhttps://github.com/geany/geany-plugins/pull/372.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/372