> I think I prefer push_in = FALSE, which I did in the last patch and which, while not ideal, looks this way:
Well, it's bad that `push_in=TRUE` doesn't scroll right away (or maybe not, so the most likely element is close to the mouse), but at least the menu sizing is decent. with FALSE, try and place the popup location close enough to the bottom and you'll see it's so small you actually can't see the items.
Also, with `push_in=TRUE`, the initial state is not great, but you can scroll it and it gets it right then.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/406#issuecomment-185984555
I kept your `$(…_TARGETS)` format here, because apparently Automake is not clever enough to see it's fine when it's in a nested conditional, and then spits out warnings. Ironic as we have just this in other conditionals in the same file, but well.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/commit/91a8bb6c6aa155085be370e9301cca324cea8…
Yes I revered to `&&` despite my earlier comment, because
1) makes overall diff non-existent, and
2) when there are only one command before, the `$(AM_V_at)` makes things worse -- I didn't think of that in my original point BTW.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/commit/91a8bb6c6aa155085be370e9301cca324cea8…
I've added additional keybindings so that one can have up to 9 custom commands.
Also added support for passing the document file name as a command line argument by substituting "%s" (as with the context action).
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/792
-- Commit Summary --
* Added keybindings for custom commands 4-9 and support for passing the document file name (%s) as command line argument
-- File Changes --
M src/keybindings.c (36)
M src/keybindings.h (6)
M src/tools.c (17)
-- Patch Links --
https://github.com/geany/geany/pull/792.patchhttps://github.com/geany/geany/pull/792.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/792
@b4n I tested your patches and things look pretty great. I have also addressed your comments and pushed the changes here:
https://github.com/techee/geany/tree/multi_tag_goto_2
The only thing I didn't like much was that on Ctrl+click the first item isn't selected - I think even when using Ctrl+click one should be able to just press enter to go to the first, suggested, tag. I removed the special case in the penultimate patch in the branch above.
The second problem is that the push_in parameter causes this:
I think I prefer push_in = FALSE, which I did in the last patch and which, while not ideal, looks this way:
(It would be best to have the popup over the whole screen like in the first screenshot but filled with all the values without the empty space.)
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/406#issuecomment-185929820