Oops. Yes, this must be a leftover.
Thanks for spotting and fixing this. I don't know of any side effects of `sci_get_line()` so this must be a leftover which I managed to consequently not notice :(.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/commit/798868602f268255bccce5e445686…
I will be nice to have possibility to use own pastebin service, such as https://github.com/seejohnrun/haste-server
If haste-server API is different that any of supported ones, it still be very usefull to have possibility to write own wrapper and provide URI of that wrapper to plugin.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/312
Rewrite the paste logic to use customizable and configurable pastebin services through configuration files, fixing #312. As a showcase, this PR adds support for http://fpaste.org quite painlessly in a7bf3a73b85aa8b136aa6905c2ec0905d111f76f.
**Disclaimer:** this has not yet been tested under Windows, and I suspect that looking up the path to the system configuration directory holding the pastebin service configurations shipped with the plugin might not work. This should be tested.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/338
-- Commit Summary --
* geniuspaste: Fix a memory leak
* geniuspaste: Rewrite to use configurable pastebins
* geniuspaste: Restore configuration compatibility with previous version
* geniuspaste: Simplify getting the paste title
* geniuspaste: Use constants instead of direct string lookup
* geniuspaste: Show request and response in debug mode
* geniuspaste: Add fpaste.org support
* geniuspaste: Remove unused code
-- File Changes --
M build/geniuspaste.m4 (1)
M geniuspaste/Makefile.am (2)
M geniuspaste/README (106)
A geniuspaste/data/Makefile.am (11)
A geniuspaste/data/codepad.org.conf (34)
A geniuspaste/data/dpaste.de.conf (64)
A geniuspaste/data/fpaste.org.conf (67)
A geniuspaste/data/pastebin.geany.org.conf (35)
A geniuspaste/data/sprunge.us.conf (88)
A geniuspaste/data/tinypaste.com.conf (20)
M geniuspaste/src/Makefile.am (2)
M geniuspaste/src/geniuspaste.c (755)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/338.patchhttps://github.com/geany/geany-plugins/pull/338.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/338
The [`GeanyEditorPrefs`](https://github.com/geany/geany/blob/master/src/editor.h#L93) structure has no public members yet is [public itself](https://github.com/geany/geany/blob/master/src/plugindata.h#L230), which is likely to denote some missing documentation.
Use in Geany and GP:
```console
$ git grep 'editor_prefs->'
plugins/splitwindow.c: set_line_numbers(sci, geany->editor_prefs->show_linenumber_margin);
plugins/splitwindow.c: if (!geany->editor_prefs->folding)
$ git grep 'editor_prefs->'
defineformat/src/defineformat.c: gint max = geany_data->editor_prefs->long_line_column;
geanyextrasel/src/extrasel.c: if (geany_data->editor_prefs->smart_home_key)
geanyminiscript/src/gms.c: data->editor_prefs->indentation->width,
pohelper/src/gph-plugin.c: gint line_len = geany_data->editor_prefs->line_break_column;
```
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/910
This is a little more questionable and basically just drop use of the deprecated `sci_get_contents_range()`, making the code slightly simpler and slightly less optimized. But well, as the commit message says I doubt it's an issue.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/commit/f5871f7961b9de6b93c76e49a5c36…
This one is funny :)
I guess it's a leftover of some earlier version of the code, but as is it copied every single line just to throw it away, as it passed it to a function that didn't use it. Unless I'm not aware of some weird side effects of `sci_get_line()`, but I highly doubt it.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/commit/798868602f268255bccce5e445686…