> + gtk_tree_model_get_iter(model, &iter, path);
> + gtk_tree_model_get(model, &iter, TAG_COLUMN, &tag, -1);
> + g_return_if_fail(tag);
> +
> + new_doc = document_find_by_real_path(tag->file->file_name);
> + if (!new_doc)
> + new_doc = document_open_file(tag->file->file_name, FALSE, NULL, NULL);
> +
> + if (new_doc)
> + {
> + GeanyDocument *old_doc = document_get_current();
> +
> + navqueue_goto_line(old_doc, new_doc, tag->line);
> + }
> +
> + gtk_widget_hide(tag_goto_popup);
the whole store should probably be cleared when hiding, not to keep TMTags around for no reason. note: destroying the popup would take care of this.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/406/files#r52834451
> @@ -138,6 +148,9 @@ static struct
> }
> symbol_menu;
>
> +static GtkWidget *tag_goto_popup = NULL;
> +static GtkWidget *tag_goto_tree_view = NULL;
meh, is it that important to cache the popup?
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/406/files#r52834430
> + case tm_tag_member_t:
> + case tm_tag_field_t:
> + return "classviewer-member";
> + case tm_tag_typedef_t:
> + case tm_tag_enum_t:
> + case tm_tag_union_t:
> + case tm_tag_struct_t:
> + return "classviewer-struct";
> + case tm_tag_namespace_t:
> + case tm_tag_package_t:
> + return "classviewer-namespace";
> + default:
> + break;
> + }
> + return "classviewer-struct";
> +}
FIXME: use the same icons as the symbols tree
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/406/files#r52834419