[Github-comments] [geany/geany] Enable local variables for C/C++ and improve autocompletion (PR #3185)

[elextr]

I am not really interested in this PR in its current regressed state.

> It's your choice, we can just take the current state and merge it (after some squashing) and deal headers next or you get this in with @elextr who was pretty happy with the earlier state. I'm not going to engage in further discussions if the header patch should be part of this PR or not, my time is better spend reviewing actual patches.

@kugel- so your approach is to smash and run.  You demand major changes just before merge so the PR is no longer in the state where I was pretty happy with it, completely wasting my previous work of test and inspect. And now you want to cry time poor when asked to provide discussion of the change you demanded.  Everybody is time poor, none of us are full time Geanyists, so forcing extra work on people without contributing simply makes you rude and damaging to the project.  I am also still waiting on replies to my comments on your own PRs #3178 and #1813, clearly other peoples contributions don't matter to you.

@techee as I said before I am disappointed that you chose to regress this PR before discussion with someone who is helping you, so wasting their efforts.  @kugel- is right in part, significant changes should be discussed on issues before PRs are made, then multiple partial PRs make sense and they can be smaller without large numbers of commits that need complex squashing at merge time, they should be able to be squashed flat at merge (which can't introduce bugs).  But big changes mid PR is a waste of everybodys efforts, do not do that without discussing it with them.

To you both, as I have said before, I do not use Geany for C++, the state of this PR does not help me, I was just trying to help @techee provide as useful a user experience for those who do so.   So completely disregarding that effort by demanding and making wholesale changes to the PR without any discussion has left me unhappy about engaging any further with this PR.

@kugel- correctly pointed out that there is a lack of effort available to the project ATM and incidents like this don't help, as he correctly said they suck up effort.  More discussion and planning is needed, and it does not help that contributors are in different time zones, and I appreciate the extra efforts of those for whom English is not their first language, but it is what it is.

> Ultimately, I'm even OK with merging PRs without review if it's really impossible to get any feedback (not uncommon these days, unfortunately) though it come with a kind of warning in advance.

As I noted above you have not replied to feedback on several PRs, however I agree with the sentiment, the process for simple bug fixes should be simple, an OP should be allowed to merge their own simple PRs providing warning and sufficient time is allowed (I suggest two weeks, including two weekends) if no feedback is received.  But additional features, or changes to existing features really need to be discussed more, not less, to avoid more of this sort of occurrence.  One thing I definitely agree with @kugel- is that discussions over code is not the best way to do it.

So how to progress this PR now.  

As @kugel- has said he is not blocking it whichever way, and I am no longer interested in pushing it, so that leaves @techee to decide.  Which is fair enough @techee has done all the work.

I guess @kugel- can't build and test on the train so if @techee gets the PR into an immediately mergable state, to get progress I will do a quick scan, and build and test and if ok press the green button.  But @techee whichever state you decide on, please document the intended behaviour so I know what to test.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3185#issuecomment-1121769338
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3185/c1121769338 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220509/56cbf9ef/attachment-0001.htm>