[Github-comments] [geany/geany] Enable local variables for C/C++ and improve autocompletion (PR #3185)

[Thomas Martitz]

My reviewing capacity is very limited and I don't want to discuss with you endlessly about procedural concerns. This is getting rather tragical and burns much more time and mental energy than any additional issue/pr that might come about.

It's your choice,  we can just take the current state and merge it (after some squashing) and deal headers next or you get this in with @elextr who was pretty happy with the earlier state. I'm not going to engage in further discussions if the header patch should be part of this PR or not, my time is better spend reviewing actual patches.

> I don't want to spend my time implementing something which doesn't get accepted.

I'm sorry that you're still fearing this. I tried my best to not give the impression that I would outright reject the header patch. As with any other patch, I'll accept it if it's beneficial and has a solid implementation. But I do want to asses (series of) patches in as small portions as possible (given my limited review capacity, e.g. this allows me to review in the train when I go to work) and not lumped together in huge wholesale PRs, even if that means that Geany's master branch is temporarily incomplete.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3185#issuecomment-1121546509
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3185/c1121546509 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220509/4ff3e03f/attachment.htm>