[Github-comments] [geany/geany] Enable local variables for C/C++ and improve autocompletion (PR #3185)
elextr
notifications at github.com
Thu May 5 12:18:07 UTC 2022
> it's just really hard to satisfy both of you at the same time.
Be honest, its impossible :smile:
> My personal preference would also be to merge this PR as it was (because it was reasonably well tested and there was nothing terribly wrong with it I think and also because at this point with the commits above it will take time to rebase them, and in a subsequent PR add the header stuff again).
Thats pretty much my argument. @kugel- yes it probably would have been better to do it in parts when it started, but when its done its just a waste of time and effort that you have not contributed to. I will not waste any effort on the split PR. @techee and I seem to agree on the preferable way forward, so I suggest that unless someone else chimes in then it be merged without the split.
@techee what I tried to say in the last post (sorry if its a bit incomprehensible, I was in a rush), its not as good as it could be, but I agree its an improvement on autocomplete without locals. Whichever way this goes ahead please make an issue with the other things that you think can be done, and I can add the above post to it as well.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3185#issuecomment-1118480252
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3185/c1118480252 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220505/6aeffa90/attachment.htm>
More information about the Github-comments
mailing list