<p></p>
<blockquote>
<p dir="auto">it's just really hard to satisfy both of you at the same time.</p>
</blockquote>
<p dir="auto">Be honest, its impossible <g-emoji class="g-emoji" alias="smile" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f604.png">😄</g-emoji></p>
<blockquote>
<p dir="auto">My personal preference would also be to merge this PR as it was (because it was reasonably well tested and there was nothing terribly wrong with it I think and also because at this point with the commits above it will take time to rebase them, and in a subsequent PR add the header stuff again).</p>
</blockquote>
<p dir="auto">Thats pretty much my argument.  <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/kugel-/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/kugel-">@kugel-</a> yes it probably would have been better to do it in parts when it started, but when its done its just a waste of time and effort that you have not contributed to.   I will not waste any effort on the split PR.  <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/techee/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/techee">@techee</a> and I seem to agree on the preferable way forward, so I suggest that unless someone else chimes in then it be merged without the split.</p>
<p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/techee/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/techee">@techee</a> what I tried to say in the last post (sorry if its a bit incomprehensible, I was in a rush), its not as good as it could be, but I agree its an improvement on autocomplete without locals.  Whichever way this goes ahead please make an issue with the other things that you think can be done, and I can add the above post to it as well.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/3185#issuecomment-1118480252">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ4PPF4FRCZFEAYIU3DVIO377ANCNFSM5UWGU33A">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAIOWJ6O4GIQQNNMOTDHTSLVIO377A5CNFSM5UWGU33KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOIKVKO7A.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><geany/geany/pull/3185/c1118480252</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/3185#issuecomment-1118480252",
"url": "https://github.com/geany/geany/pull/3185#issuecomment-1118480252",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>