[Github-comments] [geany/geany] Improve caching for SCI_TEXTHEIGHT (#2934)

[elextr]

Agree with @kugel- that there seems very little point in caching height of each line when all lines are the same height, guaranteed by Scintilla ["All lines of text in Scintilla are the same height"](https://www.scintilla.org/ScintillaDoc.html#TextRetrievalAndModification) so need to show it solves some actual problem.

Requesting text height from Scintilla in `goto_popup_position_func()` is unlikely to be significant given that function then creates and renders a menu popup which will be much more expensive.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2934#issuecomment-1020718342
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/2934/c1020718342 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220124/4002d9ff/attachment.htm>