<p></p>
<p dir="auto">Agree with <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/kugel-/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/kugel-">@kugel-</a> that there seems very little point in caching height of each line when all lines are the same height, guaranteed by Scintilla <a href="https://www.scintilla.org/ScintillaDoc.html#TextRetrievalAndModification" rel="nofollow">"All lines of text in Scintilla are the same height"</a> so need to show it solves some actual problem.</p>
<p dir="auto">Requesting text height from Scintilla in <code>goto_popup_position_func()</code> is unlikely to be significant given that function then creates and renders a menu popup which will be much more expensive.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2934#issuecomment-1020718342">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ6ZLAWYHXQ5OGGV32DUXX4O3ANCNFSM5FZZEXSQ">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAIOWJ7UR5V4QM7N5S3WWYTUXX4O3A5CNFSM5FZZEXS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHTLO2BQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><geany/geany/pull/2934/c1020718342</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2934#issuecomment-1020718342",
"url": "https://github.com/geany/geany/pull/2934#issuecomment-1020718342",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>