[Github-comments] [geany/geany] Crash after update to Scintilla 5.1.5 (Issue #3095)

Jiří Techet notifications at xxxxx
Wed Jan 12 14:39:09 UTC 2022


> Hang on, why do the scintilla wrapper functions need to be incompatible? There should be no harm in them returning what they did before even if scintilla changed.

I originally thought it would be confusing if direct Scintilla call were different from the wrapper functions. But now after looking at the plugins I think it would really be best to keep the wrappers working as before. @kugel- did it in https://github.com/geany/geany/pull/3098 for `sci_get_text()` and `sci_get_contents()` but `sci_get_selected_text_length()` wasn't updated this way and I think it should be done too.

> AFAICT plugins really should not be jumping into scintilla directly, is it really exposed in the API?

It is, wrappers cover only the most essential functionality but when you need something more special, you have to use the Scintilla API directly. I use it in the vimode plugin this way and in fact only use Scnitilla because mixing wrappers and scintilla looked strange in the code.

I wouldn't do anything crazy personally to mitigate the current problem, just bumping API. The remaining non-wrapper calls in g-p are just 2 plugins
```
SCI_GETTEXT: vimode, geanypg
SCI_GETSELTEXT: geanypg
```
and in general plugins really use wrappers.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3095#issuecomment-1011111553
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/issues/3095/1011111553 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220112/898f196a/attachment.htm>


More information about the Github-comments mailing list