<p></p>
<blockquote>
<p dir="auto">Hang on, why do the scintilla wrapper functions need to be incompatible? There should be no harm in them returning what they did before even if scintilla changed.</p>
</blockquote>
<p dir="auto">I originally thought it would be confusing if direct Scintilla call were different from the wrapper functions. But now after looking at the plugins I think it would really be best to keep the wrappers working as before. <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/kugel-/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/kugel-">@kugel-</a> did it in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1099651679" data-permission-text="Title is private" data-url="https://github.com/geany/geany/issues/3098" data-hovercard-type="pull_request" data-hovercard-url="/geany/geany/pull/3098/hovercard" href="https://github.com/geany/geany/pull/3098">#3098</a> for <code>sci_get_text()</code> and <code>sci_get_contents()</code> but <code>sci_get_selected_text_length()</code> wasn't updated this way and I think it should be done too.</p>
<blockquote>
<p dir="auto">AFAICT plugins really should not be jumping into scintilla directly, is it really exposed in the API?</p>
</blockquote>
<p dir="auto">It is, wrappers cover only the most essential functionality but when you need something more special, you have to use the Scintilla API directly. I use it in the vimode plugin this way and in fact only use Scnitilla because mixing wrappers and scintilla looked strange in the code.</p>
<p dir="auto">I wouldn't do anything crazy personally to mitigate the current problem, just bumping API. The remaining non-wrapper calls in g-p are just 2 plugins</p>
<pre><code>SCI_GETTEXT: vimode, geanypg
SCI_GETSELTEXT: geanypg
</code></pre>
<p dir="auto">and in general plugins really use wrappers.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/geany/geany/issues/3095#issuecomment-1011111553">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ6HHCB2SW5YQMNUTELUVWHA3ANCNFSM5LV3I2KA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAIOWJ7KYW7JNIDWZ3RVKBTUVWHA3A5CNFSM5LV3I2KKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHRCFNAI.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><geany/geany/issues/3095/1011111553</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/issues/3095#issuecomment-1011111553",
"url": "https://github.com/geany/geany/issues/3095#issuecomment-1011111553",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>