[Github-comments] [geany/geany] Crash after update to Scintilla 5.1.5 (Issue #3095)

[Thomas Martitz]

> The problem is that incrementing the API does nothing to stop plugins that have not been modified from running. Geany only tests its API is greater than that the plugin asks for.

That's fine. The majority of plugins is not affected. What the API increment achieves is that the plugin can adapt itself depending on the Geany version.

> Yes, agreed, but at least it stops plugins that have not been recompiled from running and possibly crashing.

We communicate ABI changes such that "you only need to recompile the plugins", without involving the author. That's not the case and a false signal.

> Like I said above currently we can't stop an unfixed plugin from being run, so if Geany is going to start making changes to the plugin interface with non-backward compatible crashing changes we need to introduce a test to reject plugins that say they need an API less than the new number. At least that will require the plugin author to manually change something, might prompt them to look why its needed, and will protect users from unchanged plugins crashing.

Poor users that lose all their plugins because the authors can't be bothered to bump their target API version. Because that would be necessary, even for plugins that are not affected. The only possible solution would be to check per API (e.g. in `sci_get_text()` if the calling plugin has at least API XY, and `abort()` if not) but most APIs don't even know if they're called from the core or a plugin. Outright rejecting all "old" plugins is too overarching as it hits plugins that don't use the affected APIs.

Most people will get Geany 1.39/2.0 and along with that G-P 1.39/2.0 (which is going to be fixed), so very few people will even notice. Please, don't make the problem of a few plugins to a problem for each and everyone.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3095#issuecomment-1010462350
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/issues/3095/1010462350 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220111/74f85e78/attachment.htm>