[Github-comments] [geany/geany] Crash after update to Scintilla 5.1.5 (Issue #3095)

[elextr]

> master is a development branch, nothing that has any guarantees for stability. Unless the bug remains unfixed for a long time its IMO ok to work on fixing it without hysterically reverting changes. Anyone can checkout the commit before the crash is introduced locally and work from that.

The problem with this is it is not just a problem with Geany, but plugins too, and those not in G-P could take an unknown amount of time to be fixed.

Geany is too scared of reverting, as I said its not a poor reflection on the person who merged the change, its just pragmatic.

> On our side we should definitely increment the plugin API so that plugins can adapt to the behavior (or reject running on older Geany).

> > Of course, then we have to deal with it, no question about that.

The problem is that incrementing the API does nothing to stop plugins that have not been modified from running.  Geany only tests its API is greater than that the plugin asks for.

> Incrementing the ABI, on the other hand, does not make sense. It cannot fix the plugin code. All it does is giving the false idea that recompiling the affected plugin resolves the situation.

Yes, agreed, but at least it stops plugins that have not been recompiled from running and possibly crashing.  

Like I said above currently we can't stop an unfixed plugin from being run, so if Geany is going to start making changes to the plugin interface with non-backward compatible crashing changes we need to introduce a test to reject plugins that say they need an API _less than_ the new number.  At least that will require the plugin author to manually change something, and might prompt them to look why its needed.

Have reopened since #3098 (thanks @kugel- for the quick turnaround) does not address the plugin issue.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3095#issuecomment-1010443094
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/issues/3095/1010443094 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220111/74713c82/attachment.htm>