[Github-comments] [geany/geany] Improve user experience when creating new projects, attempt 2 (PR #3042)

[Enrico Tröger]

@eht16 commented on this pull request.



> @@ -58,7 +58,7 @@ G_BEGIN_DECLS
  * @warning You should not test for values below 200 as previously
  * @c GEANY_API_VERSION was defined as an enum value, not a macro.
  */
-#define GEANY_API_VERSION 242
+#define GEANY_API_VERSION 243

Geany master already reached 243, so we should bump it again.

>  	{
-		base_path = g_strconcat(project_dir, G_DIR_SEPARATOR_S,
-			name, G_DIR_SEPARATOR_S, NULL);
+		gchar *name = g_path_get_basename(base_p);

`name` is already declared in 983 and could be just assigned here or is there any reason for re-declaring it here?
Same for line 1005.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3042#pullrequestreview-887750113
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3042/review/887750113 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220218/5dd08150/attachment.htm>