<p></p>
<p><b>@eht16</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/3042#discussion_r810334541">src/plugindata.h</a>:</p>
<pre style='color:#555'>> @@ -58,7 +58,7 @@ G_BEGIN_DECLS
  * @warning You should not test for values below 200 as previously
  * @c GEANY_API_VERSION was defined as an enum value, not a macro.
  */
-#define GEANY_API_VERSION 242
+#define GEANY_API_VERSION 243
</pre>
<p dir="auto">Geany master already reached 243, so we should bump it again.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/3042#discussion_r810335750">src/project.c</a>:</p>
<pre style='color:#555'>>      {
-               base_path = g_strconcat(project_dir, G_DIR_SEPARATOR_S,
-                       name, G_DIR_SEPARATOR_S, NULL);
+               gchar *name = g_path_get_basename(base_p);
</pre>
<p dir="auto"><code>name</code> is already declared in 983 and could be just assigned here or is there any reason for re-declaring it here?<br>
Same for line 1005.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/3042#pullrequestreview-887750113">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ3NEFEPHZGFQ2AZCCLU324AVANCNFSM5JLXLWHA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAIOWJ2QTH3MBPLI4I5ZVVLU324AVA5CNFSM5JLXLWHKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOGTU73YI.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><geany/geany/pull/3042/review/887750113</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/3042#pullrequestreview-887750113",
"url": "https://github.com/geany/geany/pull/3042#pullrequestreview-887750113",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>