[Github-comments] [geany/geany] Correct the backport of UniqueStringSet::Save to Scintilla 3.x. (#2884)

[Justin Blanchard]

> I'm rebasing my scintilla5 branch after reading this. As expected, I notice the conflict. I understood that I should keep the `sv == us.get()` line because of `string_view`, is that right?

Hi, that's correct. On the Scintilla 5 branch my code should be gleefully thrown away. :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2884#issuecomment-924332999
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20210921/4537f5ee/attachment.htm>