<p></p>
<blockquote>
<p>I'm rebasing my scintilla5 branch after reading this. As expected, I notice the conflict. I understood that I should keep the <code>sv == us.get()</code> line because of <code>string_view</code>, is that right?</p>
</blockquote>
<p>Hi, that's correct. On the Scintilla 5 branch my code should be gleefully thrown away. :)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2884#issuecomment-924332999">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ6Q76R4LMLWQ6ZORHTUDDO2RANCNFSM5DHTBCAA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AAIOWJZCORSOJCOQIHZC2TDUDDO2RA5CNFSM5DHTBCAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOG4MDHRY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2884#issuecomment-924332999",
"url": "https://github.com/geany/geany/pull/2884#issuecomment-924332999",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>