[Github-comments] [geany/geany] add @mesonbuild filetype support (#2850)

[Enrico Tröger]

Looks good!
A few questions and remarks:
- `data/filedefs/filetypes.Meson.conf` must be added in `data/Makefile.am` to `filetypes_dist`. Otherwise the config file won't be included in releases and won't be installed
- it'd be nice if we would add the filetype also to the appropriate key in the`[Groups]` section in `data/filetype_extensions.conf` (this is used to place the filetype in the corresponding group in the Document->Set filetype menu) - I'm not sure where it fits best, I guess either in Scripting or Misc
- would you mind sorting the keyword and identifiers list alphabetacally? This makes it easier to update in the future
- could we maybe use `meson.build` in `data/filetype_extensions.conf`? `*.build` might be too greedy, it seems common to me to use `meson.build` but I'm no Meson expert :D

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2850#issuecomment-917604664
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20210912/a8e1d22a/attachment.htm>